-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom URL for admin area and login page #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Rather than local preg_matches I would introduce a new
qtranxf_get_admin_base
function maybe inurl.php
- Though the regex looks ok, I would use a simpler
str_replace( [site_url(), '/'], '', admin_url() );
Creaded the function qtranxf_get_login_base for login name Created the function´qtranxf_get_admin_base for backend name Creaded test function for str_replace
I've created two new functions for backend and login name and use the str_replace instead of regex. (maybe the test is not necessary) |
Removed unnecessary test file
Thanks for the comments, I simplified the functions. |
Looks good at first sight, I'll take a closer look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to rewrite this a bit differently.
Is there something I can do ? |
I will merge it, but please test more once it's in master. |
Released in 3.15.0. |
If you use a plugin who hides the admin page on a custom url
Plugins like
https://de.wordpress.org/plugins/wp-hide-security-enhancer/
https://de.wordpress.org/plugins/hide-my-wp/
https://de.wordpress.org/plugins/wps-hide-login/
According to #1080 #443