Incompatibility with WP Security Plugin due to hard-coded path

[herrvigg]

Issue by aydancoskun
Friday Oct 21, 2016 at 19:19 GMT
Originally opened as qTranslate-Team/qtranslate-x#443

---

I wrote the email below to the maintainer of the open source security plugin for wordpress which can be found at http://wp-hide.com. His response is below my mail. He is happy to assist to fix this.

Subject: WP Hide Security Enhancer and qtranslate-x compatibility
Message:
Dear Ladies and Gentleman,
First of all - VERY Nice work!! Just about priceless actually this plugin.
However I ran into an issue with qtranslate-x.
Basically what happens is qtranslate-x is not showing up / loading on the admin backend.
The site is still being translated and all is fine but the backend stopped working.
This is ONLY when I use the custom login / admin URL feature. All other options of wp-hide can be turned on everything works as expected.
The plugin is here:
https://github.com/qTranslate-Team/qtranslate-x
I looked into it and the problem is in this file:
https://github.com/qTranslate-Team/qtranslate-x/blob/master/qtranslate_core.php
Line 166:
if(strpos($http_referer,'/wp-admin')!==FALSE){
Line 771:
if(preg_match('#^/(wp-.*\.php|wp-login/|wp-admin/|xmlrpc.php|robots.txt|oauth/)#', $path)){
When I replace wp-admin with my custom wp-admin path it works but obviously this breaks upgradability.
I noticed that they hardcoded xmlrpc.php as well and that is probably not a good idea either.
I tried to fix this with using get_option calls and get_admin_url to replace their hardcoded code but had no success.
This is why I am calling on you.
I am a coder but wp is new to me. So I am calling on your expertise. If what they are doing is incorrect because they are hardcoding something, would you please be so kind to send a pull request to them or let me know what to do and I gladly will. They seem like a very responsive team.
If the problem is with your plugin, could I ask you to fix it please. I noticed that you have several "conflict" files in your code already to work around incompatibilities.
For the time being I have to stay with wp.admin path to keep the translators able to login and do their work. But I would love to change it.
I think the concept of your plugin is brilliant and very needed.
Thanks for your attention.
Sincerely,

Response:
Thanks for your feedback.
I had few messages of similar issue with qtranslate-x, unfortunate they hard-coded certain url parts making things nonfunctional for our plugin. So far i couldn't get the chance to get in touch with the qtranslate-x developers for a filter or something which i can use and make this work. Maybe you can do that? Then please send the link (if any) so i can jump into the discussion and find a workaround fast.
Thanks
Remus

If you take a look at this and get in touch with the developer (contact@wp-hide.com) that would be most appreciated. There must be a way of using non hard coded admin urls using filters or something like that (as I said I am new to wp. I spend several hours trying to work it out on my test system so I could provide a fix and pull request but I got lost.)
Thanks a lot.

[herrvigg]

Comment by miaosun
Thursday Oct 27, 2016 at 15:07 GMT

---

I'm experiencing the exact same problem, looking forward to a fix, thanks in advance.

[herrvigg]

Comment by nsp-code
Monday May 15, 2017 at 10:27 GMT

---

This appear to be still not changed, please any head-up?

[herrvigg]

Comment by nsp-code
Monday May 15, 2017 at 10:31 GMT

---

Related issue topic at https://wordpress.org/support/topic/stop-hard-code-slugs-within-plugin-files/

[herrvigg]

Comment by getifo
Monday May 15, 2017 at 10:54 GMT

---

I hope this problem to be solved soon. these two should work together. I need both these plugins at the same time
Regards
Shahab

[herrvigg]

Should be fixed by #1324, released in 3.15.0.