Mods: generalize manual activation #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2022
The tab display is independent from its manual activation. Any module could have extra settings (e.g. ACF). Make the display dependent on the module state instead. Add a new `has_settings` field in the module defintions. Rename `load_modules_enabled` to `load_active_modules`.
8759262 to
8e6d062
Compare
spleen1981
commented
Apr 4, 2022
| @@ -73,6 +75,7 @@ public static function update_manual_enabled_modules() { | |||
| if ( $changed ) { | |||
| update_option( 'qtranslate_modules', $options_modules ); | |||
| self::load_active_modules(); | |||
| // TODO remove this action | |||
There was a problem hiding this comment.
We need to give opportunity to modules to perform activation/deactivation actions (e.g. flush rewrite rules for slugs module) on manual state change.
I don't see other clean ways than a do_action here...
There was a problem hiding this comment.
I know it's needed, but using a hook for something purely internal is a hack. No need to fix this now but it can always be designed differently ;)
The hooks are the main reason why WordPress became so popular, and one of the reasons this framework is such a huge mess.
herrvigg
reviewed
Apr 9, 2022
herrvigg
approved these changes
Apr 9, 2022
herrvigg
added a commit
that referenced
this pull request
Apr 10, 2022
Fix regression on front side with the new module handler. This a quickfix, there should not be any deps in that direction.
herrvigg
added a commit
that referenced
this pull request
Apr 10, 2022
The change with `array_merge` introduced a regression. Default values can't be applied because the unchecked options are not part of the `$_POST` data. Yet another quickfix, a proper fix would require more changes.
herrvigg
added a commit
that referenced
this pull request
Apr 10, 2022
Reorganize code by moving admin updates to admin source files. Refactor without the recently added `qtx_modules_update` action. Re-use `qtranslate_save_config` which is almost equivalent, except the rules will be rewritten in any case when slugs is activated, regardress of the changes in options or not. Remove other option change detection, not really needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
slugswe introduced the manual activation of a module, adding a checkbox in the integration panel (admin).Extend this feature to any module, so the activation checkbox is displayed for any module.
This checkbox only applies when all the conditions are met to activate the module (parent plugin activated and no incompatible plugin).