Mods: display settings tabs from state #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tab display is independent from its manual activation. Any module could have extra settings (e.g. ACF). Make the display dependent on the module state instead. Add a new `has_settings` field in the module defintions. Rename `load_modules_enabled` to `load_active_modules`.
herrvigg
commented
Apr 3, 2022
spleen1981
approved these changes
Apr 3, 2022
spleen1981
pushed a commit
to spleen1981/qtranslate-xt
that referenced
this pull request
Apr 3, 2022
The tab display is independent from its manual activation. Any module could have extra settings (e.g. ACF). Make the display dependent on the module state instead. Add a new `has_settings` field in the module defintions. Rename `load_modules_enabled` to `load_active_modules`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tab display is independent from its manual activation.
Any module could have extra settings (e.g. ACF).
Make the display dependent on the module state instead.
Add a new
has_settingsfield in the module defintions.Rename
load_modules_enabledtoload_active_modules.