Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KPRepublic BM40HSRGB keyboard #9860

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Add KPRepublic BM40HSRGB keyboard #9860

merged 5 commits into from
Jul 30, 2020

Conversation

tominabox1
Copy link
Contributor

@tominabox1 tominabox1 commented Jul 29, 2020 •
edited by zvecr
Loading

Description

The current sale page for the BM40 references building firmware from kbfirmware.com and is really confusing so I just figured I'd take care of the port to the master line. I don't own one of these but helped someone set up their board and it appears to work as intended with this code set.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team July 29, 2020 02:55
tzarc
tzarc requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a few things.

keyboards/bm40hsrgb/bm40hsrgb.c Show resolved Hide resolved
keyboards/bm40hsrgb/bm40hsrgb.h Show resolved Hide resolved
keyboards/bm40hsrgb/config.h Show resolved Hide resolved
keyboards/bm40hsrgb/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/bm40hsrgb/config.h Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/config.h Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/config.h Outdated Show resolved Hide resolved
@tzarc tzarc requested a review from a team July 29, 2020 03:02
@tzarc tzarc added the keyboard label Jul 29, 2020
zvecr
zvecr requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we were kinda waiting for a port would include rgb matrix rather than rgb light. (Though maybe at this point "something is better than nothing"?)

keyboards/bm40hsrgb/config.h Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/readme.md Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/readme.md Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/rules.mk Outdated Show resolved Hide resolved
keyboards/bm40hsrgb/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team July 29, 2020 03:05
@tominabox1
Copy link
Contributor Author

Also, we were kinda waiting for a port would include rgb matrix rather than rgb light. (Though maybe at this point "something is better than nothing"?)

I would love to do that but since I don't actually have the board in hand, and I'm not sure how the matrix is set up, it'd be pretty tough to do.

@tominabox1
Add license statements, cleaned up config, readme, and rules. Removed…
4097058 
… unused features from keymap and added ascii for Adjust layer
zvecr
zvecr requested changes Jul 29, 2020
View reviewed changes
keyboards/bm40hsrgb/config.h Outdated Show resolved Hide resolved
@ncwhale
Copy link
Contributor

ncwhale commented Jul 29, 2020

Also, we were kinda waiting for a port would include rgb matrix rather than rgb light. (Though maybe at this point "something is better than nothing"?)

RGB Matrix is just another DISPLAY port, though it uses digit output driver for differnet point.

Maybe I will get it done next keyboard(need powerful chips for this job.

Atmega32U4 can only process 60fps BW image real time.

@zvecr
Copy link
Member

zvecr commented Jul 29, 2020 •
edited
Loading

@ncwhale I think you misunderstand. Rgb matrix works with ws2812 as well as ISSI based boards. Plenty of boards in the repo already have it enabled, and this is a board that is a prime target for it given it has per key rgb (though there are some ws2812 timer related shortcomings on AVR chips right now which are potentially highlighted by certain parts of rgb matrix and light) .

fauxpark
fauxpark requested changes Jul 29, 2020
View reviewed changes
keyboards/bm40hsrgb/info.json Outdated Show resolved Hide resolved
tominabox1 and others added 2 commits July 29, 2020 08:17
@tominabox1 @fauxpark
Update keyboards/bm40hsrgb/info.json
5762673 
Co-authored-by: Ryan <fauxpark@gmail.com>
@tominabox1 @zvecr
Update keyboards/bm40hsrgb/config.h
250c444 
Co-authored-by: Joel Challis <git@zvecr.com>
noroadsleft
noroadsleft approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 4f7cd56 into qmk:master Jul 30, 2020
@noroadsleft
Copy link
Member

Thanks!

@tominabox1
Copy link
Contributor Author

Awesome work! Thanks for the quick turn.

@tominabox1 tominabox1 deleted the bm40hsrgb_keyboard branch July 30, 2020 12:57
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Jul 31, 2020
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
a932d60 
* 'master' of https://github.com/qmk/qmk_firmware: (156 commits)
  Add info.json for Jiran keyboard (qmk#9857)
  [Docs] Update Japanese translation of feature_ps2_mouse.md. (qmk#9815)
  [Docs] Update Japanese translation of feature_mouse_keys.md. (qmk#9809)
  [Keyboard] Add new keyboard ks63 handwired (qmk#9712)
  [keyboard] Add [n]2 support (qmk#9862)
  Timber Wolf - updated via keymap, reduced eeprom writing from backlight code (qmk#9876)
  [Docs] Update Japanese translation of feature_macros.md. (qmk#9767)
  [Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
  [Docs] Japanese translation of docs/internals_gpio_control.md (qmk#9751)
  [Docs] Japanese translation of docs/other_eclipse.md (qmk#9755)
  Added Via keymap to Spaceman 2% Milk (qmk#9484)
  Add via configuration for adelheid. (qmk#9830)
  Added Via-enabled keymap for Physix (qmk#9825)
  [Docs] Japanese translation of docs/one_shot_keys.md (qmk#9754)
  [Docs] Japanese translation of docs/mod_tap.md (qmk#9753)
  [Docs] Japanese translation of docs/how_keyboards_work.md (qmk#9683)
  [Docs] Japanese translation of docs/how_a_matrix_works.md (qmk#9682)
  [Keyboard] add bear_face/v2 (qmk#9642)
  [Keyboard] PH Arisu (qmk#9612)
  Timber Wolf - updated keymaps, fixed info.json (qmk#9787)
  ...
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@tominabox1 @nicocesar
[Keyboard] Add KPRepublic BM40HSRGB keyboard (qmk#9860)
997c7c9 
* Initial Commit

* Add readme.md's

* Add license statements, cleaned up config, readme, and rules. Removed unused features from keymap and added ascii for Adjust layer

* Update keyboards/bm40hsrgb/info.json

* Update keyboards/bm40hsrgb/config.h
@rgoulter rgoulter mentioned this pull request Aug 15, 2020
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc requested changes

@zvecr zvecr zvecr requested changes

@fauxpark fauxpark fauxpark approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BM40HSRGB Support[Feature Request]
6 participants
@tominabox1 @ncwhale @zvecr @noroadsleft @tzarc @fauxpark