[keyboard] update bm40hsrgb with RGB Matrix support #10044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Aug 15, 2020
fauxpark
requested changes
Aug 15, 2020
Co-authored-by: Ryan <fauxpark@gmail.com> - Fix alignment in keyboards/bm40rgb/bm40rgb.c - Remove redundant DESCRIPTION in keyboards/bm40rgb/config.h - Tidy keyboards/bm40rgb/readme.md - Tidy MANUFACTURER, PRODUCT in keyboards/bm40rgb/config.h - Tidy rules.mk keyboards/bm40rgb/rules.mk - Use PRODUCT_ID computed from SHASUM of keyboard name in keyboards/bm40rgb/config.h - Define LAYOUT_all in keyboards/bm40rgb/bm40rgb.h
c9b735b to
c491c62
Compare
Co-authored-by: Ryan <fauxpark@gmail.com>
|
@fauxpark Thanks for helping tidy up the code per the PR checklist. I wanted to make a WIP Draft Pull Request before going through the PR checklist. I do see that some community layouts don't build with this keyboard. Looks like most of the failures are due to |
zvecr
requested changes
Aug 15, 2020
Co-authored-by: Joel Challis <git@zvecr.com>
fauxpark
approved these changes
Aug 15, 2020
zvecr
requested changes
Aug 16, 2020
There was a problem hiding this comment.
Also the make target changing would usually mean it has to go via https://docs.qmk.fm/#/breaking_changes and target develop.
Co-authored-by: Joel Challis <git@zvecr.com>
This reverts commit 1f69a03.
|
Ah, it would be a breaking change. Hmm. I'll repurpose this PR/branch to just apply the changes that add RGB Matrix support, then. |
noroadsleft
requested changes
Aug 18, 2020
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft
approved these changes
Aug 18, 2020
|
Thanks! |
|
And I thank you code reviewers. I appreciate the patience to help iron out things that didn't fit well. 👍 |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Sep 6, 2020
* bm40rgb: copy from kbfirmware.com * bm40rgb: align default keymap * bm40rgb: rename kb.c/h to bm40rgb.c/h * bm40rgb: adjust with changes from the noroadsleft converter * bm40rgb: adjust keyboard to support plant_mit and ortho_4x12 layouts * bm40rgb: Add keyboard readme.md * bm40rgb: add RGB Matrix support * bm40rgb: remove bm40hsrgb layout * Apply suggestions from PR - Fix alignment in keyboards/bm40rgb/bm40rgb.c - Remove redundant DESCRIPTION in keyboards/bm40rgb/config.h - Tidy keyboards/bm40rgb/readme.md - Tidy MANUFACTURER, PRODUCT in keyboards/bm40rgb/config.h - Tidy rules.mk keyboards/bm40rgb/rules.mk - Use PRODUCT_ID computed from SHASUM of keyboard name in keyboards/bm40rgb/config.h - Define LAYOUT_all in keyboards/bm40rgb/bm40rgb.h * Update keyboards/bm40rgb/info.json * Tidy comment * Apply suggestions from code review * Apply suggestions from code review * Revert "bm40rgb: remove bm40hsrgb layout" This reverts commit 1f69a03. * Move the rgbmatrix change over to bm40hsrgb * Wrap g_led_config declaration with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the firmware for KPRepublic's BM40RGB keyboard that #9860 added.
This PR includes support for RGB Matrix.
Description
This PR updates the bm40hsrgb keyboard, adding RGB Matrix support.
I've tested this bm40rgb's RGB matrix functionality with my BM40RGB keyboard.
Types of Changes
Issues Fixed or Closed by This PR
Checklist