Move kbdpad_mk2 to kbdpad/mk2 and remove clutter #9221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
May 27, 2020
| @@ -27,17 +27,17 @@ | |||
| */ | |||
| #define LAYOUT_ortho_6x4( \ | |||
There was a problem hiding this comment.
@ai03-2725 could you help with this one?
Which 3 pads are not used with the numpad_6x4 layout on this pcb?
|
The first GB for this product ran nearly a year ago, and is already well into its second or third production run |
|
Needs conflict resolution. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the board's official product page, it's "coming soon", so I believe this is not (yet) a breaking change.
@ai03-2725 can comment on this.
Types of Changes
Issues Fixed or Closed by This PR
Checklist