Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Keyboard: orange75 #4093

Merged
merged 8 commits into from
Oct 9, 2018
Merged

New Keyboard: orange75 #4093

merged 8 commits into from
Oct 9, 2018

Conversation

captsis
Copy link
Contributor

@captsis captsis commented Oct 8, 2018

New keyboard for the database. modified OG foxlab code to better meet guidelines, and added an info.json .
Foxlab never pulled their repo so I thought id do it.

captsis and others added 2 commits October 7, 2018 20:43
@captsis @fox-lab
New Keyboard: orange75
189ca34 
Co-Authored-By: fox-lab <fox-lab@users.noreply.github.com>
@captsis
Update keyboards/orange75/info.json
10ffe41 
corrected
noroadsleft
noroadsleft requested changes Oct 8, 2018
View reviewed changes
keyboards/orange75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/orange75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/orange75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/orange75/orange75.h Outdated Show resolved Hide resolved
keyboards/orange75/orange75.h Show resolved Hide resolved
keyboards/orange75/rules.mk Outdated Show resolved Hide resolved
keyboards/orange75/rules.mk Outdated Show resolved Hide resolved
keyboards/orange75/info.json Show resolved Hide resolved
keyboards/orange75/info.json Outdated Show resolved Hide resolved
@captsis
Copy link
Contributor Author

captsis commented Oct 8, 2018

Thank you! correcting...

noroadsleft
noroadsleft requested changes Oct 8, 2018
View reviewed changes
keyboards/orange75/orange75.h Outdated Show resolved Hide resolved
keyboards/orange75/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/orange75/info.json Show resolved Hide resolved
@noroadsleft
Copy link
Member

Regarding the review on info.json, your help might be needed here for a future PR.

I read through the Geekhack thread that is linked in the readme. The key at K014 that doesn't exist is actually for split Backspace, but it's not clear from the thread which part of the split Backspace it's for. The info.json file tells the Configurator how to assign the keycodes that the user chooses. Right now, the file won't do that properly because there's not enough JSON objects in the right place in the file (there's 80 objects but orange75.h says there's 82 keys). I can fix it, but I'd need someone who has an ATMega32u4-powered Orange75 to test the changes as I don't own the board in question.

noroadsleft
noroadsleft requested changes Oct 8, 2018
View reviewed changes
keyboards/orange75/readme.md Outdated
A 75% made by Fox Lab.

Keyboard Maintainer: [captsis](https://github.com/captsis), [fox-lab](https://github.com/fox-lab)
Hardware Supported: Orange75 QMK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note here about this firmware supporting only the 32u4 version of the Orange75 would be good. Perhaps

Hardware Supported: Orange75 powered by the ATmega32U4

I bring this up only because QMK can power the 32A Bootmapper Client version of the PCB as well, but that one would need different source code from the 32U4 version. The Rama M65-A is an example of this.

@captsis
Copy link
Contributor Author

captsis commented Oct 8, 2018

I own the board in question. I can test it!

@captsis
Copy link
Contributor Author

captsis commented Oct 8, 2018 •
edited
Loading

I have a feeling this is probably related. I have not been able to get my backspace, pipe, up, or down key working even after swapping switches. This leads me to believe its a software issue.

drashna
drashna requested changes Oct 8, 2018
View reviewed changes
keyboards/orange75/config.h Outdated Show resolved Hide resolved
keyboards/orange75/config.h Outdated Show resolved Hide resolved
keyboards/orange75/orange75.h Outdated Show resolved Hide resolved
keyboards/orange75/rules.mk Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Oct 8, 2018
View reviewed changes
keyboards/orange75/orange75.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Oct 9, 2018

Yeah, you have to push your commits to github before they'll show up :)

@drashna
Copy link
Member

drashna commented Oct 9, 2018

Looks good!

@drashna drashna merged commit be227b4 into qmk:master Oct 9, 2018
@noroadsleft noroadsleft mentioned this pull request Oct 9, 2018
Merged
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Oct 20, 2018
@captsis @zer09
Keyboard: add orange75 (qmk#4093)
96dcf73 
* New Keyboard: orange75

Co-Authored-By: fox-lab <fox-lab@users.noreply.github.com>

* Update keyboards/orange75/info.json

corrected

*  qmk#4093 corrections

* added del to layout again

* clarified supported hardware

* directives...

* Update keyboards/orange75/config.h

* Update keyboards/orange75/readme.md
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Jan 24, 2019
@tenderlove
Merge branch 'master' into merging
a144afb 
* master: (447 commits)
  Add documentation for Combo feature
  Cleanup learning newb links
  Update and cleanup AVR Hardware docs
  Keymap: DZ60 layout based on stephengrier's with PgUp/PgDn/Home/End, Insert, etc. (qmk#4110)
  evil80: Add readme.md file
  Added cheese keymap to tada68. (qmk#4105)
  Orange75: cleanup and Configurator support update (qmk#4101)
  Keymaps: Helix rgblight mode update (qmk#4091)
  Massdrop keyboards console device support for hid_listen
  Specify max layers supported in layer keycodes
  Update default Planck layout to be more in line with standard conventions
  Fix formatting in Unicode text
  Added link to One Shot Keys
  Added OSL to list of layer toggles
  Keymap: Iris Keymap  (qmk#4100)
  Keyboard: add orange75 (qmk#4093)
  DC01 updates and I2C avr speed overwrite (qmk#4088)
  Update Bluetooth docs (qmk#4062)
  feat: Add 68Keys.io
  Keymap: Personal Nyquist keymap added. (qmk#4059)
  ...
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@captsis @rseymour
Keyboard: add orange75 (qmk#4093)
08d849a 
* New Keyboard: orange75

Co-Authored-By: fox-lab <fox-lab@users.noreply.github.com>

* Update keyboards/orange75/info.json

corrected

*  qmk#4093 corrections

* added del to layout again

* clarified supported hardware

* directives...

* Update keyboards/orange75/config.h

* Update keyboards/orange75/readme.md
yamad pushed a commit to yamad/qmk_firmware that referenced this pull request Apr 10, 2019
@captsis @yamad
Keyboard: add orange75 (qmk#4093)
dfa911e 
* New Keyboard: orange75

Co-Authored-By: fox-lab <fox-lab@users.noreply.github.com>

* Update keyboards/orange75/info.json

corrected

*  qmk#4093 corrections

* added del to layout again

* clarified supported hardware

* directives...

* Update keyboards/orange75/config.h

* Update keyboards/orange75/readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@captsis @noroadsleft @drashna