Personal Nyquist keymap added. #4059
Conversation
|
|
||
| void matrix_init_user(void) { | ||
| _delay_ms(20); // Gets rid of tick | ||
| set_unicode_input_mode(UC_LNX); |
There was a problem hiding this comment.
You should only need to set this once. Once it's set, you're good to go.
Also the delay isn't actually needed.
There was a problem hiding this comment.
What do you mean 'only set it once'? Should this be defined somewhere else/in a different fashion?
There was a problem hiding this comment.
Nope. This function actually writes to EEPROM, so it should be loaded automatically on future loads. In theory.
There was a problem hiding this comment.
Okay, so what I got from this, was:
- get rid of the
matrix_init_user()function since it's already set and doing this would set it twice - use
UC_LNX(unicode_map_index)to send unicode strings up to 0xFFFF (which the defined emojis fall under)
Am I correct in this, or just completely missing what you're saying? :)
There was a problem hiding this comment.
So the above did not work since it wouldn't compile.
I just removed the delay like you said, but no clue how I can correctly input these unicodes otherwise, so no real changes there.
If I'm missing something from the docs, please do explain because I'm not seeing it :)
Removed unnecessary imports. Updated way of macros. Removed tick from unicode inputs.
|
@drashna Could you take a look at my current config? I've done most except for the unicode stuff, since I don't really get what needs to be changed. |
|
Awesome, looks good! |
* Personal Nyquist keymap added. * Responded to comments for PR. Removed unnecessary imports. Updated way of macros. Removed tick from unicode inputs. * formatting in keymap
* master: (447 commits) Add documentation for Combo feature Cleanup learning newb links Update and cleanup AVR Hardware docs Keymap: DZ60 layout based on stephengrier's with PgUp/PgDn/Home/End, Insert, etc. (qmk#4110) evil80: Add readme.md file Added cheese keymap to tada68. (qmk#4105) Orange75: cleanup and Configurator support update (qmk#4101) Keymaps: Helix rgblight mode update (qmk#4091) Massdrop keyboards console device support for hid_listen Specify max layers supported in layer keycodes Update default Planck layout to be more in line with standard conventions Fix formatting in Unicode text Added link to One Shot Keys Added OSL to list of layer toggles Keymap: Iris Keymap (qmk#4100) Keyboard: add orange75 (qmk#4093) DC01 updates and I2C avr speed overwrite (qmk#4088) Update Bluetooth docs (qmk#4062) feat: Add 68Keys.io Keymap: Personal Nyquist keymap added. (qmk#4059) ...
* Personal Nyquist keymap added. * Responded to comments for PR. Removed unnecessary imports. Updated way of macros. Removed tick from unicode inputs. * formatting in keymap
* Personal Nyquist keymap added. * Responded to comments for PR. Removed unnecessary imports. Updated way of macros. Removed tick from unicode inputs. * formatting in keymap
I hope I get the conventions right from the first time now.
Nothing fancy, just a keymap which works for me, always great to share with the rest.