Adds TheVan RoadKit Gamepad Layout #4090
Conversation
| @@ -0,0 +1,8 @@ | |||
| #ifndef CONFIG_USER_H | |||
There was a problem hiding this comment.
If you could replace the include guard (the ifndef, define, and endif at the end) with just #pragma once?
It's simpler, and less prone to user error, so if you could make this switch?
| #ifndef CONFIG_USER_H | ||
| #define CONFIG_USER_H | ||
|
|
||
| #include "../../config.h" |
There was a problem hiding this comment.
This line is not actually needed, and should be removed.
Specifically, the build script automatically includes all of the config.h files, so this is not necessary.
| ), | ||
| }; | ||
|
|
||
| void persistent_default_layer_set(uint16_t default_layer) { |
There was a problem hiding this comment.
Could you remove this function?
It's been depreciated in favor of the set_single_persistent_default_layer function (which is a core function).
https://docs.qmk.fm/#/ref_functions?id=setting-the-persistent-default-layer
| switch (id) { | ||
| case 0: | ||
| if (record->event.pressed) { | ||
| persistent_default_layer_set(1UL << 0); |
There was a problem hiding this comment.
Could you replace this function with set_single_persistent_default_layer (and remove the 1UL << part)
| default_layer_set(default_layer); | ||
| } | ||
|
|
||
| const macro_t *action_get_macro(keyrecord_t *record, uint8_t id, uint8_t opt) { |
There was a problem hiding this comment.
Could you convert this over to process_record_user, as we have depreciated action_get_macro`?
It should be a pretty direct port.
| RGBLIGHT_ENABLE = no # Enable WS2812 RGB underlight. Do not enable this with audio at the same time. | ||
| SLEEP_LED_ENABLE = no # Breathing sleep LED during USB suspend | ||
|
|
||
| ifndef QUANTUM_DIR |
There was a problem hiding this comment.
Could you remove this (ifndef/include/endif) block?
It's not needed, and is a holdover from the old build system.
|
Thanks for the advice @drashna. I copied another folder for the RoadKit that must've been outdated. Let me know if you see any issues with the changes I pushed up. |
|
Yeah, we've been updating a lot of the boards with the newer stuff, but we haven't gotten to this one yet. So that's why. But thanks! And nice! |
* 'master' of git://github.com/qmk/qmk_firmware: Keymap: Adds TheVan RoadKit Gamepad Layout (qmk#4090) Update and clarify Unicode documentation (qmk#4065) Update Contrib doc (qmk#4068) Add non-US Hash and Backslash to AutoShift handling Keymap: Update keyboards/planck/keymaps/vifon (qmk#4084)
* adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * removes unused code * removes more code * simplify code
* adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * removes unused code * removes more code * simplify code
* adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * adds prototype firmware for wavebeem-gamepad * adds installer script * updates readme * updates title * removes unused code * removes more code * simplify code
I didn't see any gamepad style layouts so I thought I would contribute mine