Update Contrib doc #4068
Merged
Update Contrib doc #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vomindoraan
suggested changes
Oct 4, 2018
docs/contributing.md
Outdated
| }; | ||
|
|
||
| int foo(void) { | ||
| if (cond1) { |
There was a problem hiding this comment.
Maybe make this some_condition, cond1 seems oddly specific (I know I wrote this lol).
vomindoraan
reviewed
Oct 4, 2018
docs/contributing.md
Outdated
| @@ -57,7 +57,7 @@ Never made an open source contribution before? Wondering how contributions work | |||
| Most of our style is pretty easy to pick up on, but right now it's not entirely consistent. You should match the style of the code surrounding your change, but if that code is inconsistent or unclear use the following guidelines: | |||
|
|
|||
| * We indent using two spaces (soft tabs) | |||
| * We use One True Brace Style | |||
| * We use [One True Brace Style](http://google.github.io/styleguide/javaguide.html) (java specific things should be ignored) | |||
There was a problem hiding this comment.
With the example, I don't think this link is needed. Adding Java into the mix might just make things confusing.
There was a problem hiding this comment.
Perhaps we need the word modified here?
- We use a modified One True Brace Style
skullydazed
approved these changes
Oct 4, 2018
vomindoraan
reviewed
Oct 4, 2018
| @@ -57,7 +57,7 @@ Never made an open source contribution before? Wondering how contributions work | |||
| Most of our style is pretty easy to pick up on, but right now it's not entirely consistent. You should match the style of the code surrounding your change, but if that code is inconsistent or unclear use the following guidelines: | |||
|
|
|||
| * We indent using two spaces (soft tabs) | |||
| * We use One True Brace Style | |||
| * We use a modified One True Brace Style | |||
There was a problem hiding this comment.
I'd say it's a One True Brace Style variant rather than a modification. But I'm nitpicking here, feel free to ignore me.
|
Awesome - thanks! |
akatrevorjay
added a commit
to akatrevorjay/qmk_firmware
that referenced
this pull request
Oct 8, 2018
* 'master' of git://github.com/qmk/qmk_firmware: Keymap: Adds TheVan RoadKit Gamepad Layout (qmk#4090) Update and clarify Unicode documentation (qmk#4065) Update Contrib doc (qmk#4068) Add non-US Hash and Backslash to AutoShift handling Keymap: Update keyboards/planck/keymaps/vifon (qmk#4084)
zer09
pushed a commit
to zer09/qmk_firmware
that referenced
this pull request
Oct 20, 2018
* Add link for style * ignore java * Add example and update link? * Minor fixes * Change 1TBS text * comments
rseymour
pushed a commit
to rseymour/qmk_firmware
that referenced
this pull request
Mar 13, 2019
* Add link for style * ignore java * Add example and update link? * Minor fixes * Change 1TBS text * comments
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Add link for style * ignore java * Add example and update link? * Minor fixes * Change 1TBS text * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.