Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19337 #19338

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Fix #19337 #19338

merged 1 commit into from
Dec 15, 2022

Conversation

bashu
Copy link
Contributor

@bashu bashu commented Dec 15, 2022

Description

Moved LAYER_STATE_8BIT from draculad/config.h to draculad/keymaps/default/config.h, now I can build both default (with VIA_ENABLE=yes) and manna-harbour_miryoku keymaps.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sorry, something went wrong.

@drashna drashna requested a review from a team December 15, 2022 06:42
@drashna
Copy link
Member

drashna commented Dec 15, 2022

Just a heads up, if you put "closes" or "fixes" before the issue number (in the description area), github will automatically close that issue when the PR is merged.

I've already gone ahead and done this for you, so you don't need to do anything. Just wanted to let you know.

@drashna drashna merged commit 293a9fb into qmk:master Dec 15, 2022
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Building manna-harbour_miryoku keymap on draculad fails
3 participants