Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LAYER_STATE_8BIT #13

Closed
wants to merge 1 commit into from
Closed

Remove LAYER_STATE_8BIT #13

wants to merge 1 commit into from

Conversation

bashu
Copy link
Contributor

@bashu bashu commented Dec 14, 2022

I can't build miryoku layout for draculad, when LAYER_STATE_8BIT defined

I can't build miryoku layout for draculad, when LAYER_STATE_8BIT defined
@manna-harbour
Copy link
Owner

For changes to QMK outside of Miryoku QMK, please submit a PR direct to QMK. In this case, please rebase your change on QMK master and target that branch in the PR. For reference, draculad is maintained by @MangoIV, but this line was added in qmk/qmk_firmware#11930 by @tzarc. Also see #12.

@tzarc
Copy link
Contributor

tzarc commented Dec 15, 2022

For future reference, draculad:default and draculad:via are what QMK uses to ensure things continue to build with continued development.
During qmk/qmk_firmware#11930 it showed that the binaries produced were over-size, and swapping to 8-bit layer state rectified the size issue for that PR.

Both the default and via keymaps used less than 8 layers, which was why this was changed.

@manna-harbour
Copy link
Owner

manna-harbour commented Dec 15, 2022

@tzarc Thanks for the further explanation. I saw that it was noted in qmk/qmk_firmware#11930.

Some keyboards have had slight modifications made in order to ensure that they still build due to firmware size restrictions.

However, the change should have been added to keyboards/draculad/keymaps/default/config.h instead (there is no via). Adding it to keyboards/draculad/config.h means that draculad is now only compatible with keymaps 8 layers or less. Also, default currently builds without that line.

The firmware size is fine - 25844/28672 (90%, 2828 bytes free)

@tzarc
Copy link
Contributor

tzarc commented Dec 15, 2022

Then I'd imagine it'd be perfectly fine raising the PR originally posted here, against QMK itself.

@bashu
Copy link
Contributor Author

bashu commented Dec 15, 2022

done, qmk/qmk_firmware#19338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants