Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Adding Benrestech keymap for the Crkbd #18163

Merged
merged 8 commits into from
Sep 26, 2022

Conversation

BenResTech
Copy link
Contributor

Description

Adding current iteration of my keymap for the Crkbd.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/crkbd/keymaps/benrestech/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/benrestech/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/benrestech/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/benrestech/keymap.c Outdated Show resolved Hide resolved
BenResTech and others added 2 commits August 30, 2022 09:33
Reflects upstream change.
Co-authored-by: Drashna Jaelre <drashna@live.com>
@BenResTech
Copy link
Contributor Author

Updated in light of your suggestions @drashna, thanks!

@drashna drashna requested a review from a team August 30, 2022 09:52
keyboards/crkbd/keymaps/benrestech/keymap.c Outdated Show resolved Hide resolved
keyboards/crkbd/keymaps/benrestech/rules.mk Outdated Show resolved Hide resolved
@BenResTech BenResTech requested a review from fauxpark August 30, 2022 10:30
@drashna drashna merged commit 1b9de35 into qmk:master Sep 26, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants