Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Added Handwired 87 keys #17682

Merged
merged 12 commits into from
Sep 26, 2022
Merged

[Keyboard] Added Handwired 87 keys #17682

merged 12 commits into from
Sep 26, 2022

Conversation

KD-MM2
Copy link
Contributor

@KD-MM2 KD-MM2 commented Jul 14, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved into the handwired folder

@drashna
Copy link
Member

drashna commented Jul 14, 2022

Please don't close and re-open PRs: #17622

Also,

Yeah, I'm really not comfortable about the name here. ProMicro is a name that technically belongs to SparkFun. And as this isn't a board that is released by them, having it as part of the name is at best sketchy.

@KD-MM2 KD-MM2 requested a review from zvecr July 14, 2022 22:17
@qmk-ci
Copy link

qmk-ci bot commented Jul 14, 2022

QMK CI Run, PR #17682

Commit SHA1: 8364773e02d164d99f89d676195fb961451403ef
  Base SHA1: be568177435c94a7c18217c5486e2df1062c3d73

Build succeeded. See the CI output for more information.

@KD-MM2 KD-MM2 changed the title add promicro87 add hwpm87 Jul 14, 2022
@qmk-ci
Copy link

qmk-ci bot commented Jul 14, 2022

QMK CI Run, PR #17682

Commit SHA1: 0d80f4d4b7a4c16cfa36699b2cba415eb4308d3a
  Base SHA1: be568177435c94a7c18217c5486e2df1062c3d73

Build succeeded. See the CI output for more information.

@qmk-ci
Copy link

qmk-ci bot commented Jul 14, 2022

QMK CI Run, PR #17682

Commit SHA1: 03f5ff1ea910ab9d88120c8a25554fd48bc3e486
  Base SHA1: be568177435c94a7c18217c5486e2df1062c3d73

Build succeeded. See the CI output for more information.

drashna
drashna reviewed Jul 16, 2022
View reviewed changes
keyboards/handwired/hwpm87/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/hwpm87/info.json Outdated Show resolved Hide resolved
@KD-MM2 KD-MM2 changed the title add hwpm87 [Keyboard] Added Handwired 87 keys Jul 17, 2022
@KD-MM2 KD-MM2 requested a review from drashna July 20, 2022 03:27
@zvecr @drashna
Update keyboards/handwired/hwpm87/readme.md
6d0bda6 
Co-authored-by: Drashna Jaelre <drashna@live.com>
zvecr
zvecr requested changes Jul 20, 2022
View reviewed changes
keyboards/handwired/hwpm87/readme.md Outdated Show resolved Hide resolved
@KD-MM2 @zvecr
Update keyboards/handwired/hwpm87/readme.md
4e50633 
Co-authored-by: Joel Challis <git@zvecr.com>
@KD-MM2 KD-MM2 requested a review from zvecr July 22, 2022 18:42
@KD-MM2 KD-MM2 requested a review from keyboard-magpie July 25, 2022 05:41
@KD-MM2 @drashna
Update keyboards/handwired/hwpm87/rules.mk
71d9508 
Co-authored-by: Drashna Jaelre <drashna@live.com>
drashna
drashna requested changes Aug 9, 2022
View reviewed changes
keyboards/handwired/hwpm87/config.h Outdated Show resolved Hide resolved
keyboards/handwired/hwpm87/info.json Show resolved Hide resolved
KD-MM2 and others added 2 commits August 10, 2022 21:10
@KD-MM2 @drashna
Update keyboards/handwired/hwpm87/config.h
748c7c0 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@KD-MM2 @drashna
Update keyboards/handwired/hwpm87/info.json
0b98bf7 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team August 11, 2022 01:51
@drashna drashna merged commit 6809f15 into qmk:master Sep 26, 2022
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Oct 2, 2022
@KD-MM2 @drashna
@zvecr @tacahiroy
[Keyboard] Add Handwired 87 keys (qmk#17682)
eab3cd2 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@KD-MM2 @drashna @zvecr
[Keyboard] Add Handwired 87 keys (qmk#17682)
ccb359b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@KD-MM2 @drashna
@zvecr @ramonimbao
[Keyboard] Add Handwired 87 keys (qmk#17682)
d9e11e1 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@KD-MM2 @drashna
@zvecr @nolanseaton
[Keyboard] Add Handwired 87 keys (qmk#17682)
56b90b2 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@keyboard-magpie keyboard-magpie Awaiting requested review from keyboard-magpie

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KD-MM2 @drashna @fauxpark @zvecr @keyboard-magpie