Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Pro Micro 87 keys" #17622

Closed
wants to merge 1 commit into from
Closed

add "Pro Micro 87 keys" #17622

wants to merge 1 commit into from

Conversation

KD-MM2
Copy link
Contributor

@KD-MM2 KD-MM2 commented Jul 11, 2022

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@myst729
Copy link
Contributor

myst729 commented Jul 11, 2022

Just wondering why this is named after "Pro micro" 😆

@JiaGengChang
Copy link

Seems to be named pro micro because it involves soldering wires directly to the mcu (see the image in the readme here: https://i.imgur.com/SvZ9rGQ.jpeg). I could be wrong.

@drashna
Copy link
Member

drashna commented Jul 11, 2022

Yeah, I'm really not comfortable about the name here. ProMicro is a name that technically belongs to SparkFun. And as this isn't a board that is released by them, having it as part of the name is at best sketchy.

@myst729 myst729 mentioned this pull request Jul 12, 2022
14 tasks
@drashna drashna mentioned this pull request Jul 14, 2022
14 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants