Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KPrepublic bm80v2 ISO Refactor #17660

Merged
merged 9 commits into from
Jul 14, 2022
Merged

KPrepublic bm80v2 ISO Refactor #17660

merged 9 commits into from
Jul 14, 2022

Conversation

noroadsleft
Copy link
Member

Description

  • reworks the layout macro and keymaps to be compatible with QMK's tkl_iso community layout
    Enter keycode moves to home row
  • assigns @edwardslau as maintainer
  • corrects layout data in info.json
  • cleans up formatting in rules.mk, info.json and readme.md
  • assign ISO-specific keycodes to their appropriate places in the keymaps

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 13, 2022
@noroadsleft noroadsleft requested a review from a team July 13, 2022 12:29
@tzarc tzarc requested a review from a team July 13, 2022 13:14
@noroadsleft noroadsleft merged commit 928be32 into qmk:master Jul 14, 2022
@noroadsleft noroadsleft deleted the rf/kprepublic_bm80v2_iso branch July 14, 2022 06:34
WonderBeat pushed a commit to post-engineering/qmk_firmware that referenced this pull request Jul 16, 2022
Merge branch 'master' of github.com:qmk/qmk_firmware
b165cf2 
* 'master' of github.com:qmk/qmk_firmware: (179 commits)
  [Keymap] Crkbd/thunderbird2086 (qmk#16973)
  Suavity Ehan Refactor (qmk#17694)
  feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761)
  FJLabs Solanis Refactor (qmk#17686)
  [Keyboard] add ProjectCain Relic (qmk#15577)
  [Keyboard] eHan Keyboard (qmk#15861)
  Move ins, home and pgup keys to the left (qmk#17690)
  [Keymap] emp keymap for keebio/iris (qmk#16858)
  Ignore kbfirmware exports (qmk#17687)
  [Keyboard] Added TutelPad keyboard (qmk#16975)
  [Keyboard] Add Chocofly v1 (qmk#17289)
  KB16-01: correct QMK Configurator key sequence (qmk#17670)
  Nayeon Community Layout support (qmk#17665)
  [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681)
  [Keyboard] Readme file correction (qmk#17674)
  KPrepublic BM80v2 ISO Refactor (qmk#17660)
  [Keyboard] MechWild BB Steno (qmk#17163)
  [Keyboard] Modelm101 teensy2 (qmk#16805)
  Ducky One 2 SF touch-up (qmk#17672)
  Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668)
  ...
smocky pushed a commit to smocky/qmk_firmware that referenced this pull request Jul 22, 2022
@noroadsleft @smocky
KPrepublic BM80v2 ISO Refactor (qmk#17660)
31359dd 
* bm80v2_iso.h: convert tabs to spaces

* bm80v2_iso.h: use ___ for KC_NO

* bm80v2_iso.h: use QMK 3-character notation

* refactor macro for tkl_iso Community Layout compatibility

- move the matrix position identifier for Enter to the home row

* info.json: correct layout data

* rules.mk: tidy-up formatting

* readme.md: tidy-up formatting

* update maintainer; re-assign copyright

* assign ISO-appropriate keycodes in keymaps
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
@noroadsleft @schattenbrot
KPrepublic BM80v2 ISO Refactor (qmk#17660)
2780da0 
* bm80v2_iso.h: convert tabs to spaces

* bm80v2_iso.h: use ___ for KC_NO

* bm80v2_iso.h: use QMK 3-character notation

* refactor macro for tkl_iso Community Layout compatibility

- move the matrix position identifier for Enter to the home row

* info.json: correct layout data

* rules.mk: tidy-up formatting

* readme.md: tidy-up formatting

* update maintainer; re-assign copyright

* assign ISO-appropriate keycodes in keymaps
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@noroadsleft @imhoffman
KPrepublic BM80v2 ISO Refactor (qmk#17660)
e64d994 
* bm80v2_iso.h: convert tabs to spaces

* bm80v2_iso.h: use ___ for KC_NO

* bm80v2_iso.h: use QMK 3-character notation

* refactor macro for tkl_iso Community Layout compatibility

- move the matrix position identifier for Enter to the home row

* info.json: correct layout data

* rules.mk: tidy-up formatting

* readme.md: tidy-up formatting

* update maintainer; re-assign copyright

* assign ISO-appropriate keycodes in keymaps
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@noroadsleft @nolanseaton
KPrepublic BM80v2 ISO Refactor (qmk#17660)
e376e01 
* bm80v2_iso.h: convert tabs to spaces

* bm80v2_iso.h: use ___ for KC_NO

* bm80v2_iso.h: use QMK 3-character notation

* refactor macro for tkl_iso Community Layout compatibility

- move the matrix position identifier for Enter to the home row

* info.json: correct layout data

* rules.mk: tidy-up formatting

* readme.md: tidy-up formatting

* update maintainer; re-assign copyright

* assign ISO-appropriate keycodes in keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @tzarc @fauxpark