[Keyboard] Add Chocofly v1 #17289
Merged
[Keyboard] Add Chocofly v1 #17289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Jun 2, 2022
drashna
requested changes
Jun 2, 2022
drashna
approved these changes
Jun 3, 2022
fauxpark
requested changes
Jun 9, 2022
winder
commented
Jun 9, 2022
Co-authored-by: Ryan <fauxpark@gmail.com>
noroadsleft
requested changes
Jul 14, 2022
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
noroadsleft
reviewed
Jul 15, 2022
Comment on lines
+18
to
+22
| // required for my PC | ||
| #undef KC_VOLU | ||
| #undef KC_VOLD | ||
| #define KC_VOLU KC__VOLUP | ||
| #define KC_VOLD KC__VOLDOWN |
There was a problem hiding this comment.
Strange that the standard keycode wouldn't work. 😕
|
Thanks! |
WonderBeat
pushed a commit
to post-engineering/qmk_firmware
that referenced
this pull request
Jul 16, 2022
* 'master' of github.com:qmk/qmk_firmware: (179 commits) [Keymap] Crkbd/thunderbird2086 (qmk#16973) Suavity Ehan Refactor (qmk#17694) feat(keebwerk): added VIA support keymap for keebwerk nano slider (qmk#16761) FJLabs Solanis Refactor (qmk#17686) [Keyboard] add ProjectCain Relic (qmk#15577) [Keyboard] eHan Keyboard (qmk#15861) Move ins, home and pgup keys to the left (qmk#17690) [Keymap] emp keymap for keebio/iris (qmk#16858) Ignore kbfirmware exports (qmk#17687) [Keyboard] Added TutelPad keyboard (qmk#16975) [Keyboard] Add Chocofly v1 (qmk#17289) KB16-01: correct QMK Configurator key sequence (qmk#17670) Nayeon Community Layout support (qmk#17665) [Keyboard] Fix Tractyl Manuform 4x6 json (qmk#17681) [Keyboard] Readme file correction (qmk#17674) KPrepublic BM80v2 ISO Refactor (qmk#17660) [Keyboard] MechWild BB Steno (qmk#17163) [Keyboard] Modelm101 teensy2 (qmk#16805) Ducky One 2 SF touch-up (qmk#17672) Gentoo & Gentoo Hotswap: correct Configurator key sequence errors (qmk#17668) ...
smocky
pushed a commit
to smocky/qmk_firmware
that referenced
this pull request
Jul 22, 2022
* [Keyboard] Add Chocofly v1 * PR Feedback * Small change to keymap. * Replace KC__VOLUP and KC__VOLDOWN with single underscore version. * Apply suggestions from code review * Required for my PC * Required for my PC
schattenbrot
pushed a commit
to schattenbrot/qmk_firmware
that referenced
this pull request
Aug 2, 2022
* [Keyboard] Add Chocofly v1 * PR Feedback * Small change to keymap. * Replace KC__VOLUP and KC__VOLDOWN with single underscore version. * Apply suggestions from code review * Required for my PC * Required for my PC
imhoffman
pushed a commit
to imhoffman/qmk_firmware
that referenced
this pull request
Aug 20, 2022
* [Keyboard] Add Chocofly v1 * PR Feedback * Small change to keymap. * Replace KC__VOLUP and KC__VOLDOWN with single underscore version. * Apply suggestions from code review * Required for my PC * Required for my PC
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
* [Keyboard] Add Chocofly v1 * PR Feedback * Small change to keymap. * Replace KC__VOLUP and KC__VOLDOWN with single underscore version. * Apply suggestions from code review * Required for my PC * Required for my PC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for the open source chocofly keyboard.
Types of Changes
Checklist