Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k34 keyboard #15250

Merged
merged 13 commits into from
Dec 18, 2021
Merged

Add k34 keyboard #15250

merged 13 commits into from
Dec 18, 2021

Conversation

wongjingping
Copy link

@wongjingping wongjingping commented Nov 21, 2021

Add a keyboard for a custom k34 keyboard that I designed recently.

Description

This creates the folder structure and required files to build and flash the firmware for standard pro-micro MCU's. Instructions are in the readme.md

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Added a keyboard for the k34. The only thing missing is the layout in the info.json which is quite complicated for this ortho layout and have left out for the time being.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, info.json missing

keyboards/k34/rules.mk Outdated Show resolved Hide resolved
keyboards/k34/config.h Outdated Show resolved Hide resolved
keyboards/k34/k34.h Outdated Show resolved Hide resolved
keyboards/k34/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/k34/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/k34/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team November 22, 2021 20:16
keyboards/k34/readme.md Outdated Show resolved Hide resolved
keyboards/k34/readme.md Outdated Show resolved Hide resolved
keyboards/k34/readme.md Show resolved Hide resolved
renamed layout
added description and bootloader instructions
hosted img on imgur
keyboards/k34/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also missing an info.json.

added license to keymap
added info.json
{
"label":"E",
"x":2,
"y":-0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key coordinates should be positive numbers. Please check this file is correct by pressing Ctrl+Shift+I in the Configurator.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to the unconventional layout of the keys it seems - let me know if this is a blocker that I should resolve.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it doesn't look correct. You need to redo it without the rotation on the keys (I can see one of them has a rounding error) and place the sides together.
image

Use the Configurator to test the file, by pressing Ctrl+Shift+I. You can also make sure the keys are in the same order as the layout macro by turning on Fast Input.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-12-05 at 10 20 35 PM

Hmm I'm not sure why but it seems like the negative number is still there after I import it with ctrl-shift-I. Any tips for how to fix that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you generated it from the KLE, you have to fix that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to 0 instead of a negative number - would that work?

@drashna drashna self-requested a review December 4, 2021 06:30
@wongjingping
Copy link
Author

Also, info.json missing

Added an info.json. Given that this uses an unconventional layout, the positions are a little "abnormal".

keyboards/k34/rules.mk Outdated Show resolved Hide resolved
keyboards/k34/readme.md Outdated Show resolved Hide resolved
keyboards/k34/rules.mk Outdated Show resolved Hide resolved
keyboards/k34/info.json Outdated Show resolved Hide resolved
keyboards/k34/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 18, 2021 03:24
@wongjingping
Copy link
Author

Also, info.json missing

added info.json

@drashna drashna merged commit f79e1ab into qmk:master Dec 18, 2021
mattgauf added a commit to mattgauf/qmk_firmware that referenced this pull request Dec 20, 2021
* master: (581 commits)
  Add Superlyra keyboard + group with Lyra under new directory (qmk#14955)
  MechBrewery MB65S Refactor (qmk#15515)
  [Keyboard] Add k34 keyboard (qmk#15250)
  [Keyboard] update new keyboard zoom65_lite (qmk#15218)
  [Keyboard] Add Borderland (qmk#15501)
  [Keyboard] Nasu (qmk#15468)
  [Keyboard] Remove locking support for Sweep (qmk#15494)
  [Keyboard] Remove locking support from Cradio (qmk#15495)
  [Keyboard] Remove locking support for Macro3 (qmk#15496)
  [Keyboard] Add WestM (qmk#15459)
  Fix inverted gt and lt send_string mapping in canadian multilingual (qmk#15487)
  [Keyboard] removed extra layout from jorne.h (qmk#15491)
  [Keyboard] Add Jorne (qmk#15461)
  Fix some wrong keycode macros in locale mapping files (qmk#15488)
  [Core] Fix Sensor driver code (qmk#15484)
  [Keymap] Unicode and Pointing Device and Autocorect for drashna keymaps (qmk#15415)
  [Keyboard] Adelie Firmware (qmk#13265)
  [Keyboard] Add Elite-C DFU bootloader commands for Sweep (qmk#15449)
  [Keyboard] W1-AT addition (qmk#15467)
  [Keyboard] Add swap hands support for Technik_O (qmk#15477)
  ...
epiciskandar pushed a commit to epiciskandar/qmk_firmware that referenced this pull request Dec 21, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: jingpingw <jingpingw@twitter.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants