-
-
Notifications
You must be signed in to change notification settings - Fork 40.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k34 keyboard #15250
Add k34 keyboard #15250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, info.json
missing
renamed layout added description and bootloader instructions hosted img on imgur
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing an info.json.
added license to keymap added info.json
keyboards/k34/info.json
Outdated
{ | ||
"label":"E", | ||
"x":2, | ||
"y":-0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key coordinates should be positive numbers. Please check this file is correct by pressing Ctrl+Shift+I in the Configurator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to the unconventional layout of the keys it seems - let me know if this is a blocker that I should resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't look correct. You need to redo it without the rotation on the keys (I can see one of them has a rounding error) and place the sides together.
Use the Configurator to test the file, by pressing Ctrl+Shift+I. You can also make sure the keys are in the same order as the layout macro by turning on Fast Input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming you generated it from the KLE, you have to fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to 0 instead of a negative number - would that work?
Added an info.json. Given that this uses an unconventional layout, the positions are a little "abnormal". |
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
added info.json |
* master: (581 commits) Add Superlyra keyboard + group with Lyra under new directory (qmk#14955) MechBrewery MB65S Refactor (qmk#15515) [Keyboard] Add k34 keyboard (qmk#15250) [Keyboard] update new keyboard zoom65_lite (qmk#15218) [Keyboard] Add Borderland (qmk#15501) [Keyboard] Nasu (qmk#15468) [Keyboard] Remove locking support for Sweep (qmk#15494) [Keyboard] Remove locking support from Cradio (qmk#15495) [Keyboard] Remove locking support for Macro3 (qmk#15496) [Keyboard] Add WestM (qmk#15459) Fix inverted gt and lt send_string mapping in canadian multilingual (qmk#15487) [Keyboard] removed extra layout from jorne.h (qmk#15491) [Keyboard] Add Jorne (qmk#15461) Fix some wrong keycode macros in locale mapping files (qmk#15488) [Core] Fix Sensor driver code (qmk#15484) [Keymap] Unicode and Pointing Device and Autocorect for drashna keymaps (qmk#15415) [Keyboard] Adelie Firmware (qmk#13265) [Keyboard] Add Elite-C DFU bootloader commands for Sweep (qmk#15449) [Keyboard] W1-AT addition (qmk#15467) [Keyboard] Add swap hands support for Technik_O (qmk#15477) ...
Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jingpingw <jingpingw@twitter.com>
Add a keyboard for a custom k34 keyboard that I designed recently.
Description
This creates the folder structure and required files to build and flash the firmware for standard pro-micro MCU's. Instructions are in the readme.md
Types of Changes
Added a keyboard for the k34. The only thing missing is the layout in the
info.json
which is quite complicated for this ortho layout and have left out for the time being.Checklist