Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adelie Firmware #13265

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Adelie Firmware #13265

merged 12 commits into from
Dec 15, 2021

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Jun 20, 2021 •
edited
Loading

Description

Adding the Adelie keyboard to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 20, 2021
@awkannan awkannan mentioned this pull request Jun 20, 2021
Merged
6 tasks
@drashna
Apply suggestions from code review
fcf98ff 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team August 7, 2021 16:12
fauxpark
fauxpark requested changes Aug 7, 2021
View reviewed changes
keyboards/cannonkeys/adelie/config.h Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/readme.md Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/info.json Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Sep 21, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@fauxpark
Apply suggestions from code review
5dda414 
Co-authored-by: Ryan <fauxpark@gmail.com>
@stale stale bot removed the awaiting changes label Oct 14, 2021
@awkannan
Copy link
Contributor Author

Thanks @fauxpark ! I have finally addressed the comments. Apologies for the delay.

fauxpark
fauxpark requested changes Oct 14, 2021
View reviewed changes
keyboards/cannonkeys/adelie/rules.mk Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/rules.mk Outdated Show resolved Hide resolved
keyboards/cannonkeys/adelie/info.json Outdated Show resolved Hide resolved
Andrew Kannan and others added 3 commits December 14, 2021 14:07
@fauxpark
Update keyboards/cannonkeys/adelie/rules.mk
2e9be70 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark
Update keyboards/cannonkeys/adelie/rules.mk
1fb257f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark
Update keyboards/cannonkeys/adelie/info.json
190639c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@awkannan
Copy link
Contributor Author

@fauxpark once again have iterated on this to bring it up to date

fauxpark
fauxpark requested changes Dec 15, 2021
View reviewed changes
keyboards/cannonkeys/adelie/rules.mk Outdated Show resolved Hide resolved
@fauxpark
Update keyboards/cannonkeys/adelie/rules.mk
9452d5a 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna
Copy link
Member

drashna commented Dec 15, 2021

Thanks!

@drashna drashna merged commit c10bc9f into qmk:master Dec 15, 2021
mattgauf added a commit to mattgauf/qmk_firmware that referenced this pull request Dec 20, 2021
@mattgauf
Merge branch 'master' into private/mattgauf-gmmk-pro
9e88eb5 
* master: (581 commits)
  Add Superlyra keyboard + group with Lyra under new directory (qmk#14955)
  MechBrewery MB65S Refactor (qmk#15515)
  [Keyboard] Add k34 keyboard (qmk#15250)
  [Keyboard] update new keyboard zoom65_lite (qmk#15218)
  [Keyboard] Add Borderland (qmk#15501)
  [Keyboard] Nasu (qmk#15468)
  [Keyboard] Remove locking support for Sweep (qmk#15494)
  [Keyboard] Remove locking support from Cradio (qmk#15495)
  [Keyboard] Remove locking support for Macro3 (qmk#15496)
  [Keyboard] Add WestM (qmk#15459)
  Fix inverted gt and lt send_string mapping in canadian multilingual (qmk#15487)
  [Keyboard] removed extra layout from jorne.h (qmk#15491)
  [Keyboard] Add Jorne (qmk#15461)
  Fix some wrong keycode macros in locale mapping files (qmk#15488)
  [Core] Fix Sensor driver code (qmk#15484)
  [Keymap] Unicode and Pointing Device and Autocorect for drashna keymaps (qmk#15415)
  [Keyboard] Adelie Firmware (qmk#13265)
  [Keyboard] Add Elite-C DFU bootloader commands for Sweep (qmk#15449)
  [Keyboard] W1-AT addition (qmk#15467)
  [Keyboard] Add swap hands support for Technik_O (qmk#15477)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awkannan @drashna @fauxpark