Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove width, height and key_count from info.json #14274

Merged
merged 15 commits into from
Sep 12, 2021
Merged

Remove width, height and key_count from info.json #14274

merged 15 commits into from
Sep 12, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 2, 2021

Description

Following on from #13728, these keys should be calculated from the layout(s) rather than explicitly declared.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 2, 2021 10:44
@github-actions github-actions bot added keymap translation via Adds via keymap and/or updates keyboard for via support and removed core labels Sep 2, 2021
@github-actions github-actions bot added cli qmk cli command python labels Sep 2, 2021
@fauxpark
Copy link
Member Author

fauxpark commented Sep 2, 2021

Most of the lint errors are being fixed by #14213.

@fauxpark fauxpark mentioned this pull request Sep 7, 2021
Merged
14 tasks
@drashna drashna requested a review from a team September 8, 2021 03:50
@fauxpark fauxpark merged commit 4791cfa into qmk:master Sep 12, 2021
@fauxpark fauxpark deleted the info-json-cleanup branch September 12, 2021 04:04
cori pushed a commit to cori/qmk_firmware that referenced this pull request Sep 19, 2021
@fauxpark @cori
Remove width, height and key_count from info.json (qmk#14274)
e5102bd
sar23b pushed a commit to sar23b/qmk_firmware that referenced this pull request Sep 19, 2021
@fauxpark
Remove width, height and key_count from info.json (qmk#14274)
bf13e1b
billyjbryant pushed a commit to MetalBoards/qmk_firmware that referenced this pull request Sep 29, 2021
@fauxpark
Remove width, height and key_count from info.json (qmk#14274)
0aaf87a
@luigi311 luigi311 mentioned this pull request Oct 27, 2021
Merged
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
Remove width, height and key_count from info.json (qmk#14274)
bdf077c
@noroadsleft noroadsleft mentioned this pull request Jan 7, 2022
Closed
14 tasks
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
Remove width, height and key_count from info.json (qmk#14274)
9df8a1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
cli qmk cli command documentation enhancement keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna