Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PCB Canary60RGB from CanaryTeam #14321

Merged
merged 3 commits into from
Sep 11, 2021
Merged

New PCB Canary60RGB from CanaryTeam #14321

merged 3 commits into from
Sep 11, 2021

Conversation

AnthonyNguyen168
Copy link

Description

New PCB CANARY60RGB from CanaryTeam
It is a hotswappable layout 60 PCB, which support VIA and RGB per key.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation (just documentation for my keyboard)
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 5, 2021
zvecr
zvecr requested changes Sep 5, 2021
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also,

  • All *.c and *.h files need GPL compliant headers
  • All *.jpg files need to be removed

keyboards/canary/canary60rgb/v1/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team September 5, 2021 20:03
drashna
drashna requested changes Sep 5, 2021
View reviewed changes
keyboards/canary/canary60rgb/canary60rgb.c Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/canary60rgb.c Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/canary60rgb.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/config.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/canary/canary60rgb/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v1/config.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v1/config.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v1/rules.mk Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v1/rules.mk Outdated Show resolved Hide resolved
@AnthonyNguyen168 AnthonyNguyen168 force-pushed the canary60rgb branch 3 times, most recently from 8cfc6f0 to 70bfdb3 Compare September 6, 2021 19:28
@AnthonyNguyen168
Copy link
Author

Dear maintainers,
I resolve all your comments with care.
Can you check this pull request again?
Thanks

@AnthonyNguyen168 AnthonyNguyen168 changed the title New PCB CANARY60RGB from CanaryTeam New PCB Canary60RGB from CanaryTeam Sep 6, 2021
fauxpark
fauxpark requested changes Sep 6, 2021
View reviewed changes
keyboards/canary/canary60rgb/v1/config.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/info.json Outdated Show resolved Hide resolved
@AnthonyNguyen168
Copy link
Author

AnthonyNguyen168 commented Sep 7, 2021 •
edited
Loading

I committed the necessary changes and answered the questions.
Please consider this pull request.

fauxpark
fauxpark requested changes Sep 7, 2021
View reviewed changes
keyboards/canary/canary60rgb/info.json Outdated Show resolved Hide resolved
@AnthonyNguyen168 @fauxpark
Update keyboards/canary/canary60rgb/info.json
1c5bbe7 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AnthonyNguyen168
Copy link
Author

I did commit with your request.
Please check again.

@AnthonyNguyen168
Copy link
Author

Dear QMK maintainers,
Please check this pull request. :)
Thanks.

@AnthonyNguyen168
Copy link
Author

Dear @fauxpark and @zvecr,
Please check this pull request. :)
Many thanks.

@drashna
Copy link
Member

drashna commented Sep 11, 2021

Thanks!

@drashna drashna merged commit 0472917 into qmk:master Sep 11, 2021
mplilly pushed a commit to mplilly/qmk_firmware that referenced this pull request Sep 11, 2021
@AnthonyNguyen168 @fauxpark
[Keyboard] New PCB Canary60RGB from CanaryTeam (qmk#14321)
d27c573 
Co-authored-by: Ryan <fauxpark@gmail.com>
cori pushed a commit to cori/qmk_firmware that referenced this pull request Sep 19, 2021
@AnthonyNguyen168 @fauxpark @cori
[Keyboard] New PCB Canary60RGB from CanaryTeam (qmk#14321)
6e80f8e 
Co-authored-by: Ryan <fauxpark@gmail.com>
billyjbryant pushed a commit to MetalBoards/qmk_firmware that referenced this pull request Sep 29, 2021
@AnthonyNguyen168 @fauxpark
[Keyboard] New PCB Canary60RGB from CanaryTeam (qmk#14321)
55caf45 
Co-authored-by: Ryan <fauxpark@gmail.com>
@AnthonyNguyen168 AnthonyNguyen168 mentioned this pull request Oct 12, 2021
Merged
6 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@AnthonyNguyen168 @fauxpark @nhongooi
[Keyboard] New PCB Canary60RGB from CanaryTeam (qmk#14321)
74cfe44 
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyNguyen168 @drashna @fauxpark @zvecr