Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] YMDK YMD40 v2 #11835

Merged
merged 4 commits into from
Feb 14, 2021
Merged

[Keyboard] YMDK YMD40 v2 #11835

merged 4 commits into from
Feb 14, 2021

Conversation

noroadsleft
Copy link
Member

Description

Was alerted to the existence of this board by a user on Discord. Snagged the KBFirmware JSON file from the listing and ran it through my online converter, then did some optimization tweaks.

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- factory keymap is as assigned by the extracted JSON provided by the vendor
- default keymap is based on the Planck
@noroadsleft noroadsleft mentioned this pull request Feb 10, 2021
6 tasks
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noroadsleft noroadsleft merged commit ecbbdbc into qmk:master Feb 14, 2021
@noroadsleft noroadsleft deleted the kb/ymd40_v2 branch February 14, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants