Add brightness level API to OLED driver #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Oct 26, 2020
tzarc
approved these changes
Oct 26, 2020
zvecr
approved these changes
Oct 26, 2020
oscarcarlsson
pushed a commit
to oscarcarlsson/qmk_firmware
that referenced
this pull request
Nov 2, 2020
* Add brightness level API to OLED driver * Set default brightness to 255
ringmaster
pushed a commit
to ringmaster/qmk_firmware
that referenced
this pull request
Nov 5, 2020
* Add brightness level API to OLED driver * Set default brightness to 255
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Nov 8, 2020
* Add brightness level API to OLED driver * Set default brightness to 255
nicsuzor
added a commit
to nicsuzor/qmk_firmware
that referenced
this pull request
Nov 14, 2020
* upstream/master: (636 commits) [Keyboard] Adding info.json files for NIBBLE 65% keyboard (qmk#10769) [Keymap] Add KiCad keymap for ANAVI Macro Pad 8 (qmk#10766) [Keymap] add an autoclicker to my plaid keymap (qmk#10743) Roadster Edit (qmk#10784) [Keyboard] Redox via support added (qmk#10710) [Keyboard] Adding Little Alby the Arduino Keyboard (qmk#10713) Add brightness level API to OLED driver (qmk#10772) [Keyboard] Add via keymap to E6.5 (qmk#10771) [Keyboard] Add via keymap for percent booster (qmk#10768) xelus/kangaroo: fix info.json layout macro reference (qmk#10765) [Keyboard] Added polilla keyboard (squashed) (qmk#10686) docs(massdrop alt/ctrl): update link to loader releases (qmk#10781) [Keyboard] KBDfans Bella Soldered tidy-up (qmk#10753) [Keyboard] Add Via support for TG4x (qmk#10571) GEN ONE Eclipse_65 keyboard addition (qmk#10669) VN66 refactor (qmk#10776) Stella refactor (qmk#10775) [Keymap] greatwizard userspace and ortho 4x12 and 5x12 keymaps (qmk#9584) add rsync to the api update process [Keyboard] Add Projectkb/alice/rev2 LAYOUT_alice support (qmk#10697) ...
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Nov 24, 2020
* Add brightness level API to OLED driver * Set default brightness to 255
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 13, 2021
* Add brightness level API to OLED driver * Set default brightness to 255
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Add brightness level API to OLED driver * Set default brightness to 255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔅 🔆
The SSD1306 datasheet calls this "contrast", probably a holdover from LCDs, but since OLEDs emit light, it is actually brightness.
The VCOM deselect level was changed from 0x40 to 0x20 in order to get what seems (to me) to be a larger brightness range - at 0x40 the OLED is quite bright but at brightness level 0, the display only dims a little bit. Likewise, when set to 0x00, the maximum brightness is noticeably dimmer, but the minimum is much dimmer. 0x20 appears to be the sweet spot from my 5 seconds of experimentation (I also note that this is the value upon reset). Maybe there is some way to dynamically change the VCOM deselect along with the brightness level...
Types of Changes
Issues Fixed or Closed by This PR
Checklist