Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing info.json files for NIBBLE 65% keyboard #10769

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

jaygreco
Copy link
Contributor

Description

Added info.json files for the NIBBLE keyboard. Currently, toolbox can't download the NIBBLE firmwares, and I presume it's the lack of an info.json file causing this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@jaygreco jaygreco marked this pull request as draft October 26, 2020 03:13
@jaygreco jaygreco marked this pull request as ready for review October 26, 2020 04:10
@drashna drashna requested review from noroadsleft, a team and yanfali October 29, 2020 06:52
@fauxpark
Copy link
Member

I don't think a missing info.json is the cause of the default keymap not being pushed to qmk.fm. I can compile it locally, which is all that's needed from what I can tell. This PR may solve it incidentally by kicking off another build attempt, though.

@drashna drashna merged commit 4e72224 into qmk:master Oct 29, 2020
oscarcarlsson pushed a commit to oscarcarlsson/qmk_firmware that referenced this pull request Nov 2, 2020
ringmaster pushed a commit to ringmaster/qmk_firmware that referenced this pull request Nov 5, 2020
tacahiroy pushed a commit to tacahiroy/qmk_firmware that referenced this pull request Nov 8, 2020
@jaygreco jaygreco deleted the update_nibble_json branch November 13, 2020 04:19
nicsuzor added a commit to nicsuzor/qmk_firmware that referenced this pull request Nov 14, 2020
* upstream/master: (636 commits)
  [Keyboard] Adding info.json files for NIBBLE 65% keyboard (qmk#10769)
  [Keymap] Add KiCad keymap for ANAVI Macro Pad 8 (qmk#10766)
  [Keymap] add an autoclicker to my plaid keymap (qmk#10743)
  Roadster Edit (qmk#10784)
  [Keyboard] Redox via support added (qmk#10710)
  [Keyboard] Adding Little Alby the Arduino Keyboard (qmk#10713)
  Add brightness level API to OLED driver (qmk#10772)
  [Keyboard] Add via keymap to E6.5 (qmk#10771)
  [Keyboard] Add via keymap for percent booster (qmk#10768)
  xelus/kangaroo: fix info.json layout macro reference (qmk#10765)
  [Keyboard] Added polilla keyboard (squashed) (qmk#10686)
  docs(massdrop alt/ctrl): update link to loader releases (qmk#10781)
  [Keyboard] KBDfans Bella Soldered tidy-up (qmk#10753)
  [Keyboard] Add Via support for TG4x (qmk#10571)
  GEN ONE Eclipse_65 keyboard addition (qmk#10669)
  VN66 refactor (qmk#10776)
  Stella refactor (qmk#10775)
  [Keymap] greatwizard userspace and ortho 4x12 and 5x12 keymaps (qmk#9584)
  add rsync to the api update process
  [Keyboard] Add Projectkb/alice/rev2 LAYOUT_alice support (qmk#10697)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants