Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Semantic Type for fetch-busco-db output #312

Closed
wants to merge 5 commits into from

Conversation

Sann5
Copy link
Contributor

@Sann5 Sann5 commented Feb 26, 2024

What's new

Run it locally

  1. Assuming you have a working environment and a local copy of q2-types
conda activate <your_env>
conda install -c conda-forge -c bioconda busco=5.5.1
cd <path_to>/q2-types
gh pr checkout 312
  1. Let's get you some data to play with:
cd <wherever_you_want_to_download_the_data_to>
busco --download "virus"
cd ..

FYI I can't run busco from the visual code terminal (it can find it), only from i-term.

  1. Test it out!
qiime tools import --input-path wherever_you_want_to_download_the_data_to --output-path busco_db.qza --type "ReferenceDB[BuscoDB]"

Running the tests

pytest -W ignore -vv --pyargs q2_types

@Sann5
Copy link
Contributor Author

Sann5 commented Feb 26, 2024

@misialq idk if you can review this here, but it's the pending PR in q2-types-genomics

@Sann5
Copy link
Contributor Author

Sann5 commented May 10, 2024

Hey @misialq. Do you think we can merge this? Or should I rather transfer it to q2-moshpit? In any case, Im working now on the corresponding actions so it would be good to merge it so nothing is blocked.

@misialq
Copy link
Collaborator

misialq commented May 10, 2024

Hey @Sann5, after our recent chat on the other PR I think it maybe would be better if we had it back in moshpit... This will never be used by anything else anyways so we can also just keep it contained there - sorry about that! 🙇

@Sann5 Sann5 closed this May 13, 2024
@Sann5 Sann5 deleted the st_fetch_busco_iss_74 branch May 13, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Semantic Type for fetch-busco-db's output
2 participants