Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processing] Add missing field types to the advanced (i.e. python) field calculator algorithm #47094

Merged
merged 3 commits into from
Jan 31, 2022
Merged

[processing] Add missing field types to the advanced (i.e. python) field calculator algorithm #47094

merged 3 commits into from
Jan 31, 2022

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Jan 31, 2022

Description

Turns out there was another algorithm in need of field type love:

image

This PR adds missing field types to the advanced field calculator algorithm. The PR relies on the standardized string and icon work done today.

@github-actions github-actions bot added this to the 3.24.0 milestone Jan 31, 2022
m-kuhn
m-kuhn approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@m-kuhn m-kuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, only cosmetic

@nirvn @m-kuhn
Apply suggestions from code review
ebe0fde 
Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
@nyalldawson nyalldawson merged commit 663a709 into qgis:master Jan 31, 2022
@agiudiceandrea agiudiceandrea added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Sep 14, 2024
@qgis-bot
Copy link
Collaborator

@nirvn
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

@nirvn
A documentation ticket has been opened at qgis/QGIS-Documentation#9260
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@qgis-bot qgis-bot mentioned this pull request Sep 14, 2024
Closed
@agiudiceandrea agiudiceandrea mentioned this pull request Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn approved these changes

Assignees
No one assigned
Labels
Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Milestone
3.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nirvn @qgis-bot @m-kuhn @nyalldawson @agiudiceandrea