Apply suggestions from code review

Co-authored-by: Matthias Kuhn <matthias@opengis.ch>
qgis · Jan 31, 2022 · 663a709 · 663a709
1 parent f949adc
commit 663a709
Showing 1 changed file with 14 additions and 14 deletions.
diff --git a/python/plugins/processing/algs/qgis/FieldPyculator.py b/python/plugins/processing/algs/qgis/FieldPyculator.py
@@ -66,22 +66,22 @@ def initAlgorithm(self, config=None):
         self.addParameter(QgsProcessingParameterString(self.FIELD_NAME,
                                                        self.tr('Result field name'), defaultValue='NewField'))
 
-        types = [[QVariant.Int, QVariant.Invalid],
-                 [QVariant.Double, QVariant.Invalid],
-                 [QVariant.String, QVariant.Invalid],
-                 [QVariant.Bool, QVariant.Invalid],
-                 [QVariant.Date, QVariant.Invalid],
-                 [QVariant.Time, QVariant.Invalid],
-                 [QVariant.DateTime, QVariant.Invalid],
-                 [QVariant.ByteArray, QVariant.Invalid],
-                 [QVariant.StringList, QVariant.String],
-                 [QVariant.List, QVariant.Int],
-                 [QVariant.List, QVariant.Double]]
+        types = [(QVariant.Int, QVariant.Invalid),
+                 (QVariant.Double, QVariant.Invalid),
+                 (QVariant.String, QVariant.Invalid),
+                 (QVariant.Bool, QVariant.Invalid),
+                 (QVariant.Date, QVariant.Invalid),
+                 (QVariant.Time, QVariant.Invalid),
+                 (QVariant.DateTime, QVariant.Invalid),
+                 (QVariant.ByteArray, QVariant.Invalid),
+                 (QVariant.StringList, QVariant.String),
+                 (QVariant.List, QVariant.Int),
+                 (QVariant.List, QVariant.Double)]
         type_names = []
         type_icons = []
-        for t in types:
-            type_names.append(QgsVariantUtils.typeToDisplayString(t[0], t[1]))
-            type_icons.append(QgsFields.iconForFieldType(t[0], t[1]))
+        for type_name, subtype_name in types:
+            type_names.append(QgsVariantUtils.typeToDisplayString(type_name, subtype_name))
+            type_icons.append(QgsFields.iconForFieldType(type_name, subtype_name))
         param = QgsProcessingParameterEnum('FIELD_TYPE', 'Field type', options=type_names)
         param.setMetadata({'widget_wrapper': {'icons': type_icons}})
         self.addParameter(param)