always install dependencies upfront with pip in CI #7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7645
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 1999593: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
May 31, 2023
|
Hey @malfet! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Reviewed By: vmoens Differential Revision: D46724125 fbshipit-source-id: 2ddffb76c90a56f94a671e570349f80029715faa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pinning
numpyas done in #7639, this PR reuses the pre-install logic that we have in place for Windows for all workflows. Sincepipdoes not suffer from the same issues aseasy_installthat should be more "future-proof". And take that with a grain of salt, sinceeasy_installis deprecated anyway.cc @seemethere