Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin numpy for Python 3.8 #7639

Merged
merged 1 commit into from
May 30, 2023
Merged

pin numpy for Python 3.8 #7639

merged 1 commit into from
May 30, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented May 30, 2023

Fixes #7638

cc @seemethere

@pytorch-bot
Copy link

pytorch-bot bot commented May 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7639

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 02b7975:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamping

@pmeier
Copy link
Collaborator Author

pmeier commented May 30, 2023

Something weird is going on for Linux / 3.11. Somehow,

try:
import av
# Do a version test too
torchvision.io.video._check_av_available()
except ImportError:
av = None

this leaves us with something like av = ImportError. In turn, the skips, e.g.

@pytest.mark.skipif(av is None, reason="PyAV unavailable")

don't work properly and we get errors like

Traceback (most recent call last):
  File "/work/test/test_videoapi.py", line 127, in test_frame_reading_mem_vs_file
    reader = VideoReader(full_path)
             ^^^^^^^^^^^^^^^^^^^^^^
  File "/work/torchvision/io/video_reader.py", line 171, in __init__
    self.container = av.open(src, metadata_errors="ignore")
                     ^^^^^^^
AttributeError: 'ImportError' object has no attribute 'open'

I doubt that it has something to do with this PR, but even if it has, the CI is less red afterwards. Will look into that next.

@pmeier pmeier marked this pull request as ready for review May 30, 2023 12:15
@pmeier pmeier merged commit db22668 into pytorch:main May 30, 2023
@pmeier pmeier deleted the pin-numpy branch May 30, 2023 12:15
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

pmeier added a commit to pmeier/vision that referenced this pull request May 31, 2023
facebook-github-bot pushed a commit that referenced this pull request May 31, 2023
Reviewed By: vmoens

Differential Revision: D46314046

fbshipit-source-id: a71c7d9240d930940665a834325b71c7133cbe94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toasted CI due to attempt at installing numpy-1.25.0rc1 which requires 3.9
3 participants