-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add functional vertical flip tests on segmentation mask #5860
test: add functional vertical flip tests on segmentation mask #5860
Conversation
a4da303
to
3577009
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @federicopozzi33
I left few comments
@vfdev-5 I saw that in other previous PRs, such as the ones concerning the affine or rotate primitives, you add two tests for check the correctness: one with random segmentation masks and another with a fixed input. I skipped the one with random segmentation masks for some reasons:
|
@federicopozzi33 I think it is enough as you did as vflip is not that complicated op.
Affine/rotate ops are configurable and the first correctness check is generating hundreds of subtests running on CPU only. On the other hand, fixed input correctness check is testing the op on a single test-case and on CUDA and CPU. This is a trade-off between CI runtime and exhaustive op checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@federicopozzi33 LGTM, thanks for the PR !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@federicopozzi33 Ooops there are conflicts with main branch. Could you please resolve so that we can merge? |
@datumbox I can fix them quickly right now |
c9589f7
to
30ad075
Compare
#5860) Summary: * test: add functional vertical flip tests on segmentation mask * refactor: improve test readibility * Update test_prototype_transforms_functional.py Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095725 fbshipit-source-id: 12e88faba3cc1f3bf9d9857be2e92b52634155b3 Co-authored-by: Federico Pozzi <federico.pozzi@argo.vision> Co-authored-by: vfdev <vfdev.5@gmail.com>
No description provided.