Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Implement transforms primitives for Segmentation Masks #5782

Closed
8 tasks done
vfdev-5 opened this issue Apr 7, 2022 · 9 comments
Closed
8 tasks done

[RFC] Implement transforms primitives for Segmentation Masks #5782

vfdev-5 opened this issue Apr 7, 2022 · 9 comments

Comments

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 7, 2022

Related tracker issue: #5754

Functional transforms for segmentation masks

The idea is to implement the following low-level functional transforms for segmentation masks:
https://github.com/pytorch/vision/blob/main/torchvision/prototype/transforms/functional/_geometry.py

How to test the implementation ?

Put tests into test/test_prototype_transforms_functional.py:

  • correctness test
  • eager vs scripted
  • scriptable
  • check on cpu and cuda

cc @vfdev-5 @datumbox @bjuncek

@federicopozzi33
Copy link
Contributor

Hi @vfdev-5,

I would like to work on vertical_flip_segmentation_mask primitive.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 20, 2022

@federicopozzi33 sure, go ahead!

EDIT: Currently, only tests are missing and you already coded the low-level primitive

@vadimkantorov
Copy link

Related: #4415

@federicopozzi33
Copy link
Contributor

@vfdev-5,

I'd like to go on with pad_segmentation_mask primitive.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 22, 2022

Thanks @federicopozzi33 , sure go ahead !

@federicopozzi33
Copy link
Contributor

I'd like to complete this issue doing center_crop_segmentation_mask.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented May 26, 2022

@pmeier in order to close this tracker as done we have to add more correctness tests for padding with other padding modes (https://github.com/pytorch/vision/pull/5866/files#r859158083)

pad_segmentation_mask uses pad_image_tensor and right now we does not have any tests for pad_image_tensor. I suggest to check correctness with one of suggested ways (from the link above). Later these tests could be reused for checking pad_image_tensor.

Any other suggestions from your side ?

@pmeier
Copy link
Collaborator

pmeier commented May 26, 2022

Nope, sounds like a good plan.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented May 30, 2022

I'm closing this tracker as done

@vfdev-5 vfdev-5 closed this as completed May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants