Add test for sigmoid_focal_loss #5783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
reviewed
Apr 7, 2022
Improve code by using torch.testing.make_tensor Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Remove unnecessary assert Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Refactor code for generating inputs and targets Co-authored-by: Philip Meier <github.pmeier@posteo.de>
YosuaMichael
commented
Apr 7, 2022
There was a problem hiding this comment.
Thansk @pmeier , I have made some changes and respond on your review
|
The test on GPU failed on torch.half, will investigate further why |
pmeier
reviewed
Apr 8, 2022
pmeier
approved these changes
Apr 8, 2022
datumbox
reviewed
Apr 8, 2022
datumbox
approved these changes
Apr 8, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
May 5, 2022
Summary: * Add test for sigmoid_focal_loss * Update test/test_ops.py Improve code by using torch.testing.make_tensor * Update test/test_ops.py Remove unnecessary assert * Update test/test_ops.py Refactor code for generating inputs and targets * Improve focal_loss test code suggested on comment by Philip * Use fuser2 to prevent fuser bug * Combine function to generate input, dont set the fuser when device is cpu * Add github issue for the fuser problem (Note: this ignores all push blocking failures!) Reviewed By: jdsgomes, NicolasHug Differential Revision: D36095694 fbshipit-source-id: 36ed7ece4188eef159fa7f84fc3ebdc346a63f2d Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de> Co-authored-by: Philip Meier <github.pmeier@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-task for #5688
adding test for sigmoid_focal_loss function