Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for sigmoid_focal_loss and generalized_box_iou_loss #5688

Closed
datumbox opened this issue Mar 28, 2022 · 5 comments
Closed

Add tests for sigmoid_focal_loss and generalized_box_iou_loss #5688

datumbox opened this issue Mar 28, 2022 · 5 comments

Comments

@datumbox
Copy link
Contributor

datumbox commented Mar 28, 2022

🚀 The feature

The sigmoid_focal_loss and generalized_box_iou_loss ops are not currently tested. We should create the necessary unit-tests that check the validity for multiple input types.

@oke-aditya
Copy link
Contributor

oke-aditya commented Mar 31, 2022

This will also help folks working on Ciou ad Diou loss. cc @abhi-glitchhg @yassineAlouini

@YosuaMichael I can work on this if you like :)

Reference tests fvcore
https://github.com/facebookresearch/fvcore/blob/main/tests/test_giou_loss.py

@yassineAlouini
Copy link
Contributor

Thanks @oke-aditya for the link.

@YosuaMichael
Copy link
Contributor

Hi @oke-aditya thanks for the offer! Is there anything urgent that need this test?

Currently I actually do this task for the sake of learning (since I am new and it would be good to touch as many part of the code as possible), hence I would like to do this issues myself if possible, however it would take more times.

@oke-aditya
Copy link
Contributor

Oh! Ok no problem @YosuaMichael and congratulations for your new job at Meta. Feel free to do at your pace.

@YosuaMichael
Copy link
Contributor

This issue is done with #5783 and #5792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants