Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build python 3.13t on windows #6298

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Build python 3.13t on windows #6298

merged 4 commits into from
Feb 18, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Feb 17, 2025 •
edited
Loading

Vision builds passes
For torchaudio we need pytorch/audio#3881

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2025

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 17, 2025
atalman
atalman commented Feb 18, 2025
View reviewed changes
.github/workflows/test_build_wheels_windows_without_cuda.yml Outdated
@@ -38,7 +38,7 @@ jobs:
name: ${{ matrix.repository }}
with:
repository: ${{ matrix.repository }}
ref: nightly
Copy link
Contributor Author

@atalman atalman Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary change to be removed before landing

atalman
atalman commented Feb 18, 2025
View reviewed changes
tools/scripts/generate_binary_build_matrix.py Outdated
@@ -473,7 +473,8 @@ def generate_wheels_matrix(
arches += [XPU]

if limit_pr_builds:
python_versions = [python_versions[0]]
# todo: remove before merging
python_versions = [python_versions[-1]]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary change to trigged 3.13t builds

@atalman atalman mentioned this pull request Feb 18, 2025
Merged
@atalman atalman merged commit 3ebb0ca into pytorch:main Feb 18, 2025
23 of 45 checks passed
clee2000 added a commit that referenced this pull request Feb 19, 2025
@clee2000
[ez] Fix lint and tests after #6298 (#6300)
7127f5c 
Fix lint by following lintrunner
Fix the tests by running `python -m
tools.tests.test_generate_binary_build_matrix --update-reference-files`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxiiro zxiiro zxiiro approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @zxiiro @facebook-github-bot