Skip to content

Commit

Permalink
[ez] Fix lint and tests after #6298 (#6300)
Browse files Browse the repository at this point in the history
Fix lint by following lintrunner
Fix the tests by running `python -m
tools.tests.test_generate_binary_build_matrix --update-reference-files`
  • Loading branch information
clee2000 authored Feb 19, 2025
1 parent 2c377ed commit 7127f5c
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 3 deletions.
4 changes: 1 addition & 3 deletions tools/scripts/generate_binary_build_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,9 +486,7 @@ def generate_wheels_matrix(
)

# TODO: Enable python 3.13t on xpu and cpu-s390x or Windows
if (
(gpu_arch_type in ["xpu", "cpu-s390x"])
) and python_version == "3.13t":
if (gpu_arch_type in ["xpu", "cpu-s390x"]) and python_version == "3.13t":
continue

desired_cuda = translate_desired_cuda(gpu_arch_type, gpu_arch_version)
Expand Down
60 changes: 60 additions & 0 deletions tools/tests/assets/build_matrix_windows_wheel_cuda.json
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,66 @@
"upload_to_base_bucket": "no",
"stable_version": "2.6.0",
"use_split_build": false
},
{
"python_version": "3.13t",
"gpu_arch_type": "cpu",
"gpu_arch_version": "",
"desired_cuda": "cpu",
"container_image": "pytorch/manylinux2_28-builder:cpu",
"package_type": "wheel",
"build_name": "wheel-py3_13t-cpu",
"validation_runner": "windows.4xlarge",
"installation": "pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cpu",
"channel": "nightly",
"upload_to_base_bucket": "no",
"stable_version": "2.6.0",
"use_split_build": false
},
{
"python_version": "3.13t",
"gpu_arch_type": "cuda",
"gpu_arch_version": "11.8",
"desired_cuda": "cu118",
"container_image": "pytorch/manylinux2_28-builder:cuda11.8",
"package_type": "wheel",
"build_name": "wheel-py3_13t-cuda11_8",
"validation_runner": "windows.g4dn.xlarge",
"installation": "pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu118",
"channel": "nightly",
"upload_to_base_bucket": "no",
"stable_version": "2.6.0",
"use_split_build": false
},
{
"python_version": "3.13t",
"gpu_arch_type": "cuda",
"gpu_arch_version": "12.4",
"desired_cuda": "cu124",
"container_image": "pytorch/manylinux2_28-builder:cuda12.4",
"package_type": "wheel",
"build_name": "wheel-py3_13t-cuda12_4",
"validation_runner": "windows.g4dn.xlarge",
"installation": "pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu124",
"channel": "nightly",
"upload_to_base_bucket": "no",
"stable_version": "2.6.0",
"use_split_build": false
},
{
"python_version": "3.13t",
"gpu_arch_type": "cuda",
"gpu_arch_version": "12.6",
"desired_cuda": "cu126",
"container_image": "pytorch/manylinux2_28-builder:cuda12.6",
"package_type": "wheel",
"build_name": "wheel-py3_13t-cuda12_6",
"validation_runner": "windows.g4dn.xlarge",
"installation": "pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu126",
"channel": "nightly",
"upload_to_base_bucket": "no",
"stable_version": "2.6.0",
"use_split_build": false
}
]
}
15 changes: 15 additions & 0 deletions tools/tests/assets/build_matrix_windows_wheel_xpu.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,21 @@
"upload_to_base_bucket": "yes",
"stable_version": "2.6.0",
"use_split_build": false
},
{
"python_version": "3.13t",
"gpu_arch_type": "cpu",
"gpu_arch_version": "",
"desired_cuda": "cpu",
"container_image": "pytorch/manylinux2_28-builder:cpu",
"package_type": "wheel",
"build_name": "wheel-py3_13t-cpu",
"validation_runner": "windows.4xlarge",
"installation": "pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cpu",
"channel": "nightly",
"upload_to_base_bucket": "yes",
"stable_version": "2.6.0",
"use_split_build": false
}
]
}

0 comments on commit 7127f5c

Please sign in to comment.