[cadence][hifi] Fixed all hifi ops and cmake #8551
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8551
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 6675920 with merge base a01571f ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
backends/cadence/CMakeLists.txt
Outdated
| @@ -22,7 +22,10 @@ endif() | |||
| include(${EXECUTORCH_ROOT}/build/Utils.cmake) | |||
|
|
|||
| # Let files say "include <executorch/path/to/header.h>". | |||
| set(_common_include_directories ${EXECUTORCH_ROOT}/..) | |||
| set(_common_include_directories ${EXECUTORCH_ROOT}/.. | |||
| ${EXECUTORCH_ROOT}/runtime/core/portable_type) | |||
There was a problem hiding this comment.
I believe this needs to be ${EXECUTORCH_ROOT}/runtime/core/portable_type/c10; if your build is working without it then maybe you don't need it at all?
There was a problem hiding this comment.
good catch. Surprisingly this path is required for build but still worked without c10
|
@zonglinpeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary
Test plan
backends/cadence/build_cadence_hifi4.sh