Fix shadowing of C <complex.h> by c10 include directory #8442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8442
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 42a37e2 with merge base 9ba5494 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Feb 13, 2025
New test dont_shadow_complex_test.c illustrates the previous problem; new README.md explains the fix. Test Plan: dont_shadow_complex_test.c used to fail to build, now it succeeds. ghstack-source-id: fef8d6b2a116acc8125091058abafc51d5ebab37 ghstack-comment-id: 2655201918 Pull Request resolved: #8442
c65fa7c to
07584c4
Compare
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
07584c4 to
2a1cad2
Compare
kirklandsign
approved these changes
Feb 13, 2025
|
Let's land from internal first |
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: New test dont_shadow_complex_test.c illustrates the previous problem; new README.md explains the fix. Pull Request resolved: #8442 Test Plan: dont_shadow_complex_test.c used to fail to build, now it succeeds. Reviewed By: kirklandsign Differential Revision: D69599281 Pulled By: swolchok
|
This pull request was exported from Phabricator. Differential Revision: D69599281 |
2a1cad2 to
42a37e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test dont_shadow_complex_test.c illustrates the previous problem; new README.md explains the fix.
Test Plan: dont_shadow_complex_test.c used to fail to build, now it succeeds.