Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick: Transformer XL fix to release/2.1 #2414

Merged
merged 2 commits into from
Oct 31, 2023
Merged

cherry-pick: Transformer XL fix to release/2.1 #2414

merged 2 commits into from
Oct 31, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

Type of change

  • Cherry Pick

Checklist:

  • [ - ] My code follows the style guidelines of this project (You can use the linters)
  • [ - ] I have performed a self-review of my own code
  • [ - ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ - ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
  • [ - ] New and existing unit tests pass locally with my changes
  • [ - ] I have added the relevant labels to my PR in so that relevant reviewers are notified

gs-olive and others added 2 commits October 24, 2023 11:15
@gs-olive gs-olive requested a review from narendasan October 24, 2023 18:17
@gs-olive gs-olive self-assigned this Oct 24, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests component: torch_compile documentation Improvements or additions to documentation labels Oct 24, 2023
@github-actions github-actions bot requested a review from apbose October 24, 2023 18:17
github-actions[bot]
github-actions bot approved these changes Oct 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 24, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@peri044 peri044 merged commit f1d7771 into release/2.1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@apbose apbose Awaiting requested review from apbose

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests component: torch_compile documentation Improvements or additions to documentation fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @facebook-github-bot @peri044