Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Converter, inputs, and utils bugfixes for Transformer XL #2404

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: Converter, inputs, and utils bugfixes for Transformer XL #2404

merged 1 commit into from
Oct 24, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Fix slice and sum converter bugs
    • slice incorrectly parsed negative-indexed start or end indices
    • sum needs to cast boolean tensors to int32, and can take the sum of int32 tensors
  • Add regression test cases to validate fixes
  • Fix issue where outputs can be torch.int64 when a sum of booleans is returned
  • Fix issue where inputs in torch compile were being checked for contiguity
  • Propagate fix to utility

Fixes #2400

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Converter, inputs, and utils bugfixes
3aef38a 
- Fix slice and sum converter bugs
- Add regression test cases to validate fixes
- Fix issue where inputs in torch compile were being checked for
contiguity
- Propagate fix to utility
@gs-olive gs-olive requested review from zewenli98 and apbose October 18, 2023 22:23
@gs-olive gs-olive self-assigned this Oct 18, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests component: torch_compile labels Oct 18, 2023
@github-actions github-actions bot requested a review from narendasan October 18, 2023 22:23
github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Oct 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

zewenli98
zewenli98 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

peri044
peri044 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 73e887c into main Oct 24, 2023
@gs-olive gs-olive deleted the transfo_xl_bugfixes branch October 24, 2023 17:54
gs-olive added a commit that referenced this pull request Oct 24, 2023
@gs-olive
fix: Converter, inputs, and utils bugfixes for Transformer XL (#2404)
9a59d2d
@gs-olive gs-olive mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@zewenli98 zewenli98 zewenli98 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@apbose apbose Awaiting requested review from apbose

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests component: torch_compile priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Transformer-XL Dynamo backend converter issue
4 participants
@gs-olive @peri044 @zewenli98 @facebook-github-bot