Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.13] gh-125268: Use static string for "1e309" in AST (GH-125272) #125280

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[3.13] gh-125268: Use static string for "1e309" in AST (GH-125272) #125280

merged 4 commits into from
Oct 24, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Oct 10, 2024 •
edited by bedevere-app bot
Loading

When formatting the AST as a string, infinite values are replaced by 1e309, which evaluates to infinity. The initialization of this string replacement was not thread-safe in the free threading build. (cherry picked from commit 427dcf2)

@colesbury
[3.13] pythongh-125268: Use static string for "1e309" in AST (pythonG…
cd1f221 
…H-125272)

When formatting the AST as a string, infinite values are replaced by
1e309, which evaluates to infinity. The initialization of this string
replacement was not thread-safe in the free threading build.
(cherry picked from commit 427dcf2)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2024
Closed
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2024
Merged
@colesbury colesbury requested a review from Yhg1s October 10, 2024 20:34
@Yhg1s
Copy link
Member

Yhg1s commented Oct 24, 2024

You'll have to update the ABI dump but the changes are good to go into 3.13.

@colesbury colesbury requested a review from encukou as a code owner October 24, 2024 16:34
@colesbury colesbury merged commit 4b55d53 into python:3.13 Oct 24, 2024
37 checks passed
@colesbury colesbury deleted the backport-427dcf2-3.13 branch October 24, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @Yhg1s