Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125268: Use static string for "1e309" in AST #125272

Merged
merged 1 commit into from
Oct 10, 2024
Merged

gh-125268: Use static string for "1e309" in AST #125272

merged 1 commit into from
Oct 10, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Oct 10, 2024 •
edited by bedevere-app bot
Loading

When formatting the AST as a string, infinite values are replaced by 1e309, which evaluates to infinity. The initialization of this string replacement was not thread-safe in the free threading build.

@colesbury
pythongh-125268: Use static string for "1e309" in AST
3a9e16e 
When formatting the AST as a string, infinite values are replaced by
1e309, which evaluates to infinity. The initialization of this string
replacement was not thread-safe in the free threading build.
@bedevere-app bedevere-app bot mentioned this pull request Oct 10, 2024
Closed
@colesbury colesbury merged commit 427dcf2 into python:main Oct 10, 2024
42 checks passed
@colesbury colesbury deleted the gh-125268-str-inf branch October 10, 2024 20:21
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 427dcf24de4e06d239745d74d08c4b2e541dca5a 3.13

@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2024

GH-125280 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
colesbury added a commit to colesbury/cpython that referenced this pull request Oct 10, 2024
@colesbury
[3.13] pythongh-125268: Use static string for "1e309" in AST (pythonG…
cd1f221 
…H-125272)

When formatting the AST as a string, infinite values are replaced by
1e309, which evaluates to infinity. The initialization of this string
replacement was not thread-safe in the free threading build.
(cherry picked from commit 427dcf2)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Oct 24, 2024
@colesbury
[3.13] gh-125268: Use static string for "1e309" in AST (GH-125272) (G…
4b55d53 
…H-125280)

When formatting the AST as a string, infinite values are replaced by
1e309, which evaluates to infinity. The initialization of this string
replacement was not thread-safe in the free threading build.
(cherry picked from commit 427dcf2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@colesbury colesbury

Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesbury @JelleZijlstra @Eclips4