Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123142: fix too wide source location of GET_ITER/GET_AITER #123420

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/test/support/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2850,14 +2850,17 @@ def get_signal_name(exitcode):
return None

class BrokenIter:
def __init__(self, init_raises=False, next_raises=False):
def __init__(self, init_raises=False, next_raises=False, iter_raises=False):
if init_raises:
1/0
self.next_raises = next_raises
self.iter_raises = iter_raises

def __next__(self):
if self.next_raises:
1/0

def __iter__(self):
if self.iter_raises:
1/0
return self
7 changes: 7 additions & 0 deletions Lib/test/test_dictcomps.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,15 @@ def next_raises():
except Exception as e:
return e

def iter_raises():
try:
{x:x for x in BrokenIter(iter_raises=True)}
except Exception as e:
return e

for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
(iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_iter.py
Original file line number Diff line number Diff line change
Expand Up @@ -1163,8 +1163,16 @@ def next_raises():
except Exception as e:
return e

def iter_raises():
try:
for x in BrokenIter(iter_raises=True):
pass
except Exception as e:
return e

for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
(iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_listcomps.py
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,15 @@ def next_raises():
except Exception as e:
return e

def iter_raises():
try:
[x for x in BrokenIter(iter_raises=True)]
except Exception as e:
return e

for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
(iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_setcomps.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,15 @@ def next_raises():
except Exception as e:
return e

def iter_raises():
try:
{x for x in BrokenIter(iter_raises=True)}
except Exception as e:
return e

for func, expected in [(init_raises, "BrokenIter(init_raises=True)"),
(next_raises, "BrokenIter(next_raises=True)"),
(iter_raises, "BrokenIter(iter_raises=True)"),
]:
with self.subTest(func):
exc = func()
Expand Down
15 changes: 7 additions & 8 deletions Python/compile.c
Original file line number Diff line number Diff line change
Expand Up @@ -2990,7 +2990,7 @@ codegen_async_for(struct compiler *c, stmt_ty s)
NEW_JUMP_TARGET_LABEL(c, end);

VISIT(c, expr, s->v.AsyncFor.iter);
ADDOP(c, loc, GET_AITER);
ADDOP(c, LOC(s->v.AsyncFor.iter), GET_AITER);

USE_LABEL(c, start);
RETURN_IF_ERROR(compiler_push_fblock(c, loc, FOR_LOOP, start, end, NULL));
Expand Down Expand Up @@ -5284,7 +5284,7 @@ codegen_async_comprehension_generator(struct compiler *c, location loc,
else {
/* Sub-iter - calculate on the fly */
VISIT(c, expr, gen->iter);
ADDOP(c, loc, GET_AITER);
ADDOP(c, LOC(gen->iter), GET_AITER);
}
}

Expand Down Expand Up @@ -5618,15 +5618,14 @@ pop_inlined_comprehension_state(struct compiler *c, location loc,
}

static inline int
codegen_comprehension_iter(struct compiler *c, location loc,
comprehension_ty comp)
codegen_comprehension_iter(struct compiler *c, comprehension_ty comp)
{
VISIT(c, expr, comp->iter);
if (comp->is_async) {
ADDOP(c, loc, GET_AITER);
ADDOP(c, LOC(comp->iter), GET_AITER);
}
else {
ADDOP(c, loc, GET_ITER);
ADDOP(c, LOC(comp->iter), GET_ITER);
}
return SUCCESS;
}
Expand Down Expand Up @@ -5654,7 +5653,7 @@ codegen_comprehension(struct compiler *c, expr_ty e, int type,

outermost = (comprehension_ty) asdl_seq_GET(generators, 0);
if (is_inlined) {
if (codegen_comprehension_iter(c, loc, outermost)) {
if (codegen_comprehension_iter(c, outermost)) {
goto error;
}
if (push_inlined_comprehension_state(c, loc, entry, &inline_state)) {
Expand Down Expand Up @@ -5736,7 +5735,7 @@ codegen_comprehension(struct compiler *c, expr_ty e, int type,
}
Py_CLEAR(co);

if (codegen_comprehension_iter(c, loc, outermost)) {
if (codegen_comprehension_iter(c, outermost)) {
goto error;
}

Expand Down
Loading