gh-123142: fix too wide source location of GET_ITER/GET_AITER #123420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Aug 28, 2024
•
- Issue: Source locations too broad for list comprehension iterable expression #123142
|
Skipping news because the news item from #123173 covers this. |
markshannon
approved these changes
Aug 28, 2024
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 28, 2024
…AITER (pythonGH-123420). (cherry picked from commit 61bef62) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-123435 is a backport of this pull request to the 3.13 branch. |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Aug 28, 2024
…AITER (pythonGH-123420). (cherry picked from commit 61bef62) Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
GH-123436 is a backport of this pull request to the 3.12 branch. |
iritkatriel
added a commit
that referenced
this pull request
Aug 28, 2024
iritkatriel
added a commit
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.