Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117711: Fix test_tools.test_makefile when wheeldata dir is empty #117748

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 11, 2024

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Apr 11, 2024
@vstinner vstinner marked this pull request as ready for review April 11, 2024 09:25
@vstinner
Copy link
Member Author

@sobolevn: Would you mind to review this change?

You can test the change using rm -f Lib/test/wheeldata/*. Without this change, ./python -m test -v test_tools.test_makefile fails. With this change, it works.

@hroncok
Copy link
Contributor

hroncok commented Apr 11, 2024

I kinda prefer gh-117712.

Your approach works too, but makes the test pass even if the folder is accidentally empty.

(If we are extra paranoid, we can combine both conditionals into one, but I don't think it's necessary.)

@vstinner
Copy link
Member Author

I merged PR gh-117712 instead. I close my PR.

I kinda prefer #117712. Your approach works too, but makes the test pass even if the folder is accidentally empty.

I agree with you :-) I prefer PR gh-117712 approach.

@vstinner vstinner closed this Apr 11, 2024
@vstinner vstinner deleted the wheeldata branch April 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants