gh-117711: Only check for 'test/wheeldata' when it's actually used #117712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to build Python with option `--with-wheel-pkg-dir` pointing to a custom wheel directory. Don't include the directory in the test set if the wheels are used from a different location.
hroncok
reviewed
Apr 10, 2024
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
Merged, thanks for the fix. |
|
We usually backport changes to this test to 3.12 |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 11, 2024
…sed (pythonGH-117712) It's possible to build Python with option `--with-wheel-pkg-dir` pointing to a custom wheel directory. Don't include the directory in the test set if the wheels are used from a different location. (cherry picked from commit d496387) Co-authored-by: Karolina Surma <33810531+befeleme@users.noreply.github.com> Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
GH-117749 is a backport of this pull request to the 3.12 branch. |
Oh, I didn't know that 3.12 was also affected: I confirm, a 3.12 fix is needed. |
vstinner
pushed a commit
that referenced
this pull request
Apr 11, 2024
…used (GH-117712) (#117749) gh-117711: Only check for 'test/wheeldata' when it's actually used (GH-117712) It's possible to build Python with option `--with-wheel-pkg-dir` pointing to a custom wheel directory. Don't include the directory in the test set if the wheels are used from a different location. (cherry picked from commit d496387) Co-authored-by: Karolina Surma <33810531+befeleme@users.noreply.github.com> Co-authored-by: Miro Hrončok <miro@hroncok.cz>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…sed (python#117712) It's possible to build Python with option `--with-wheel-pkg-dir` pointing to a custom wheel directory. Don't include the directory in the test set if the wheels are used from a different location. Co-authored-by: Miro Hrončok <miro@hroncok.cz>
|
Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to build Python with option
--with-wheel-pkg-dirpointing to a custom wheel directory. Don't include the directory in the test set if the wheels are used from a different location.Currently testing the patch in Fedora Linux.
test/wheeldatais empty #117711