-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLD list testing added #282
Conversation
The tests on urls.py seems to fail. I'm not sure if changes on domain.py affect the latter. Also, the domain validator depends on the internet to fetch the list of TLDs, Do we need to have a static list in case the data can't be pulled? |
Yes, URLs are composed of either ip-address or domain.
I'd prefer caching TLDs. For now, I'll put this PR on hold, because:
Feel free to work on |
Ok cool, let me look what I can do on |
|
c5f8f78
to
73d540f
Compare
Just want to bring the attention to this library that already handle this, maybe we can use it or take inspiration: |
The TLD in the domain validator are checked against a valid list of TLDs from "https://data.iana.org/TLD/tlds-alpha-by-domain.txt"
This pull request solves #198