Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does/should validators check for a static list of currently valid Top Level Domains (TLD)? #198

Closed
jlegido opened this issue Nov 25, 2021 · 3 comments · Fixed by #360
Closed
Assignees
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months

Comments

@jlegido
Copy link

jlegido commented Nov 25, 2021

First of all many thanks to all the people involved in this project, I really appreciate his/her time.

I was wondering if library is expected to simply validate a domain from a RFC standpoint or is expected to check a list of TLDs for instance.

Steps to reproduce

  1. Create a script
cat <<EOF >> test.py
#!/usr/bin/python3
from validators import domain
print(domain("sanpellegrino-corporate.itOLDWEBSITE"))
EOF
  1. Execute it
python3 test.py

Expected behaviour

False

Found behaviour

True

Errors

None

Additional information

Operating system:

Debian GNU/Linux bookworm/sid \n \l

Library version:

validators         0.18.2

Python version:

Python 3.9.9
@yozachar yozachar added enhancement Issue/PR: A new feature duplicate Issue/PR: Redundant labels Mar 2, 2023
@yozachar yozachar added the outdated Issue/PR: Open for more than 3 months label Mar 14, 2023
@maaaaz
Copy link

maaaaz commented Apr 14, 2023

I think it could be a good idea to use the daily updated list of TLD:
https://www.icann.org/resources/pages/tlds-2012-02-25-en
https://data.iana.org/TLD/tlds-alpha-by-domain.txt

@aviiciii
Copy link
Contributor

is this implemented? if not I would ilke to work on this.

@yozachar
Copy link
Collaborator

Sure, go ahead.

@yozachar yozachar added outdated Issue/PR: Open for more than 3 months and removed outdated Issue/PR: Open for more than 3 months labels Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue/PR: Redundant enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants