Lazy load credentials for legacy repositories

src/poetry/repositories/legacy_repository.py

@@ -188,12 +188,6 @@ def __init__(
             self._authenticator.session, cache=FileCache(str(self._cache_dir / "_http"))
         )
 
-        username, password = self._authenticator.get_credentials_for_url(self._url)
-        if username is not None and password is not None:
-            self._authenticator.session.auth = requests.auth.HTTPBasicAuth(
-                username, password
-            )
-
         if self._cert:
             self._authenticator.session.verify = str(self._cert)
 
@@ -212,9 +206,19 @@ def client_cert(self) -> Path | None:
 
     @property
     def authenticated_url(self) -> str:
-        if not self._session.auth:
-            return self.url
+        """
+        Set authentication credentials and return a URL with basic auth
 
+        Use self._set_authentication_creds() and self.session.get() directly
+        if you want to send a request to the repository server.
+        This function is only usefull if you need the string representation
+        of the basic auth URL. Be aware that it contains the credential in
+        plain text.
+        """
+        try:
+            self._set_authentication_creds()
+        except ValueError:
+            return self.url
         parsed = urllib.parse.urlparse(self.url)
         username = quote(self._session.auth.username, safe="")
         password = quote(self._session.auth.password, safe="")
@@ -394,9 +398,18 @@ def _get_release_info(self, name: str, version: str) -> dict:
 
         return data.asdict()
 
+    def _set_authentication_creds(self) -> None:
+        username, password = self._authenticator.get_credentials_for_url(self._url)
+        if username is None or password is None:
+            raise ValueError
+        self._authenticator.session.auth = requests.auth.HTTPBasicAuth(
+            username, password
+        )
+
     def _get_page(self, endpoint: str) -> Page | None:
         url = self._url + endpoint
         try:
+            self._set_authentication_creds()
             response = self.session.get(url)
             if response.status_code in (401, 403):
                 self._log(

tests/installation/test_chooser.py

@@ -94,7 +94,9 @@ def pool() -> Pool:
 
     pool.add_repository(PyPiRepository(disable_cache=True))
     pool.add_repository(
-        LegacyRepository("foo", "https://foo.bar/simple/", disable_cache=True)
+        LegacyRepository(
+            "foo", "https://user1:password1@foo.bar/simple/", disable_cache=True
+        )
     )
 
     return pool
@@ -113,7 +115,7 @@ def test_chooser_chooses_universal_wheel_link_if_available(
             package.version.text,
             source_type="legacy",
             source_reference="foo",
-            source_url="https://foo.bar/simple/",
+            source_url="https://user1:password1@foo.bar/simple/",
         )
 
     link = chooser.choose_for(package)

tests/repositories/test_legacy_repository.py

@@ -331,7 +331,7 @@ def test_get_package_retrieves_packages_with_no_hashes():
 
 class MockHttpRepository(LegacyRepository):
     def __init__(self, endpoint_responses: dict, http: type[httpretty.httpretty]):
-        base_url = "http://legacy.foo.bar"
+        base_url = "http://testuser1:password1@legacy.foo.bar"
         super().__init__("legacy", url=base_url, disable_cache=True)
 
         for endpoint, response in endpoint_responses.items():