Lazy load credentials for legacy repositories #4937
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move loading credentials from LegacyRepository.init() separate function and call it from _get_page() and authenticated_url()
This avoids loading credentials for commands that don't use them (e. g. poetry env list). This helps to avoid annoying users that have to unlock their keyring and if such commands are called as background tasks (CI pipelines, VS-Code environment detection).
Questions and remarks from my side:
authenticated_url()
? I'm fine with removing it._set_authentication_creds()
should be a private or public function. Tell me if you prefer it to becomeset_authentication_creds()
Resolves: #4874
Addedchanged tests for changed code.